You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/24 09:23:50 UTC
[GitHub] [airflow] mattluudo opened a new pull request #13871: Updates Oracle.rst documentation
mattluudo opened a new pull request #13871:
URL: https://github.com/apache/airflow/pull/13871
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Resolves Issue #10186 (Move Tips & Tricks for Oracle shops should be moved to Airflow Docs)
Fixes broken link, add UI connection documentation link, and connection tips.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#issuecomment-766464407
[The Workflow run](https://github.com/apache/airflow/actions/runs/508110819) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#issuecomment-766456896
[The Workflow run](https://github.com/apache/airflow/actions/runs/508053358) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mattluudo commented on pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
mattluudo commented on pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#issuecomment-766490283
@potiuk Ready to merge!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#issuecomment-766321602
Som static checks failing :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#issuecomment-766321110
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#issuecomment-766456896
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mattluudo commented on pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
mattluudo commented on pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#issuecomment-766451195
Removed trailing whitespace causing static check error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vikramkoka commented on pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
vikramkoka commented on pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#issuecomment-769159926
> The current error :
> `intersphinx inventory '/opt/airflow/docs/_inventory_cache/mongodb/objects.inv' not fetchable due to <class 'FileNotFoundError'>: [Errno 2] No such file or directory: '/opt/airflow/docs/_inventory_cache/mongodb/objects.inv' `
> is fixed by #13939 so probably just need a rebase
This error "the mongodb/objects.inv" is completed unrelated. I was running into this too when I tried building the docs using Breeze.
@kaxil fixed this "mongodb/objects.inv" error yesterday in a separate PR. I think it was a dependency change. That was fixed by the PR referenced above #13939
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vikramkoka commented on a change in pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
vikramkoka commented on a change in pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#discussion_r565669409
##########
File path: docs/apache-airflow-providers-oracle/connections/oracle.rst
##########
@@ -60,8 +63,35 @@ Extra (optional)
* ``purity`` - one of ``new``, ``self``, ``default``. Specify the session acquired from the pool.
configuration parameter.
- More details on all Oracle connect parameters supported can be found in
- `cx_Oracle documentation <https://cx-oracle.readthedocs.io/en/latest/module.html#cx_Oracle.connect>`_.
+ Connect using Dsn and Sid, Dsn and Service_name, or only Host `(OracleHook.getconn Documentation) <https://airflow.apache.org/docs/apache-airflow-providers-oracle/stable/_modules/airflow/providers/oracle/hooks/oracle.html#OracleHook.get_conn>`_.
+
+ For example:
+
+ .. code-block:: python
+
+ Host = "(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=dbhost.example.com)(PORT=1521))(CONNECT_DATA=(SERVICE_NAME=orclpdb1)))"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Service_name = "orclpdb1"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Sid = "orcl"
+
+
+ More details on all Oracle connect parameters supported can be found in `cx_Oracle documentation
+ <https://cx-oracle.readthedocs.io/en/latest/api_manual/module.html#cx_Oracle.connect>`_.
+
+ Information on creating an Oracle Connection through the web user interface can be found in Airflow's `Managing Connections Documentation
+ <https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html>`_.
Review comment:
```suggestion
Information on creating an Oracle Connection through the web user interface can be found in Airflow's :doc:`Managing Connections Documentation <apache-airflow:howto/connection>`.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vikramkoka commented on a change in pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
vikramkoka commented on a change in pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#discussion_r565657839
##########
File path: docs/apache-airflow-providers-oracle/connections/oracle.rst
##########
@@ -60,8 +63,35 @@ Extra (optional)
* ``purity`` - one of ``new``, ``self``, ``default``. Specify the session acquired from the pool.
configuration parameter.
- More details on all Oracle connect parameters supported can be found in
- `cx_Oracle documentation <https://cx-oracle.readthedocs.io/en/latest/module.html#cx_Oracle.connect>`_.
+ Connect using Dsn and Sid, Dsn and Service_name, or only Host `(OracleHook.getconn Documentation) <https://airflow.apache.org/docs/apache-airflow-providers-oracle/stable/_modules/airflow/providers/oracle/hooks/oracle.html#OracleHook.get_conn>`_.
+
+ For example:
+
+ .. code-block:: python
+
+ Host = "(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=dbhost.example.com)(PORT=1521))(CONNECT_DATA=(SERVICE_NAME=orclpdb1)))"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Service_name = "orclpdb1"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Sid = "orcl"
+
+
+ More details on all Oracle connect parameters supported can be found in `cx_Oracle documentation
+ <https://cx-oracle.readthedocs.io/en/latest/api_manual/module.html#cx_Oracle.connect>`_.
+
+ Information on creating an Oracle Connection through the web user interface can be found in Airflow's `Managing Connections Documentation
+ <https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html>`_.
Review comment:
Should do the trick, since it is referencing howto/connection.rst
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#discussion_r563611501
##########
File path: docs/apache-airflow-providers-oracle/connections/oracle.rst
##########
@@ -60,8 +63,35 @@ Extra (optional)
* ``purity`` - one of ``new``, ``self``, ``default``. Specify the session acquired from the pool.
configuration parameter.
- More details on all Oracle connect parameters supported can be found in
- `cx_Oracle documentation <https://cx-oracle.readthedocs.io/en/latest/module.html#cx_Oracle.connect>`_.
+ Connect using Dsn and Sid, Dsn and Service_name, or only Host `(OracleHook.getconn Documentation) <https://airflow.apache.org/docs/apache-airflow-providers-oracle/stable/_modules/airflow/providers/oracle/hooks/oracle.html#OracleHook.get_conn>`_.
+
+ For example:
+
+ .. code-block:: python
+
+ Host = "(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=dbhost.example.com)(PORT=1521))(CONNECT_DATA=(SERVICE_NAME=orclpdb1)))"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Service_name = "orclpdb1"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Sid = "orcl"
+
+
+ More details on all Oracle connect parameters supported can be found in `cx_Oracle documentation
+ <https://cx-oracle.readthedocs.io/en/latest/api_manual/module.html#cx_Oracle.connect>`_.
+
+ Information on creating an Oracle Connection through the web user interface can be found in Airflow's `Managing Connections Documentation
+ <https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html>`_.
Review comment:
Do we use http links for internal reference in our docs?
shouldn't this be like the security section [here](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/connection.rst#securing-connections)
So I believe it should be:
:doc:`/howto/connection/index`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13871:
URL: https://github.com/apache/airflow/pull/13871
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#issuecomment-769025942
The current error :
`intersphinx inventory '/opt/airflow/docs/_inventory_cache/mongodb/objects.inv' not fetchable due to <class 'FileNotFoundError'>: [Errno 2] No such file or directory: '/opt/airflow/docs/_inventory_cache/mongodb/objects.inv'
`
is fixed by https://github.com/apache/airflow/pull/13939 so probably just need a rebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mattluudo commented on a change in pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
mattluudo commented on a change in pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#discussion_r564130650
##########
File path: docs/apache-airflow-providers-oracle/connections/oracle.rst
##########
@@ -60,8 +63,35 @@ Extra (optional)
* ``purity`` - one of ``new``, ``self``, ``default``. Specify the session acquired from the pool.
configuration parameter.
- More details on all Oracle connect parameters supported can be found in
- `cx_Oracle documentation <https://cx-oracle.readthedocs.io/en/latest/module.html#cx_Oracle.connect>`_.
+ Connect using Dsn and Sid, Dsn and Service_name, or only Host `(OracleHook.getconn Documentation) <https://airflow.apache.org/docs/apache-airflow-providers-oracle/stable/_modules/airflow/providers/oracle/hooks/oracle.html#OracleHook.get_conn>`_.
+
+ For example:
+
+ .. code-block:: python
+
+ Host = "(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=dbhost.example.com)(PORT=1521))(CONNECT_DATA=(SERVICE_NAME=orclpdb1)))"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Service_name = "orclpdb1"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Sid = "orcl"
+
+
+ More details on all Oracle connect parameters supported can be found in `cx_Oracle documentation
+ <https://cx-oracle.readthedocs.io/en/latest/api_manual/module.html#cx_Oracle.connect>`_.
+
+ Information on creating an Oracle Connection through the web user interface can be found in Airflow's `Managing Connections Documentation
+ <https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html>`_.
Review comment:
You are correct. I will make the change suggested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mattluudo commented on pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
mattluudo commented on pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#issuecomment-766451195
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vikramkoka commented on a change in pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
vikramkoka commented on a change in pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#discussion_r565656754
##########
File path: docs/apache-airflow-providers-oracle/connections/oracle.rst
##########
@@ -60,8 +63,35 @@ Extra (optional)
* ``purity`` - one of ``new``, ``self``, ``default``. Specify the session acquired from the pool.
configuration parameter.
- More details on all Oracle connect parameters supported can be found in
- `cx_Oracle documentation <https://cx-oracle.readthedocs.io/en/latest/module.html#cx_Oracle.connect>`_.
+ Connect using Dsn and Sid, Dsn and Service_name, or only Host `(OracleHook.getconn Documentation) <https://airflow.apache.org/docs/apache-airflow-providers-oracle/stable/_modules/airflow/providers/oracle/hooks/oracle.html#OracleHook.get_conn>`_.
+
+ For example:
+
+ .. code-block:: python
+
+ Host = "(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=dbhost.example.com)(PORT=1521))(CONNECT_DATA=(SERVICE_NAME=orclpdb1)))"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Service_name = "orclpdb1"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Sid = "orcl"
+
+
+ More details on all Oracle connect parameters supported can be found in `cx_Oracle documentation
+ <https://cx-oracle.readthedocs.io/en/latest/api_manual/module.html#cx_Oracle.connect>`_.
+
+ Information on creating an Oracle Connection through the web user interface can be found in Airflow's `Managing Connections Documentation
+ <https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html>`_.
Review comment:
The underlying error was because of this:
WARNING: unknown document: /howto/connection/index
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#issuecomment-769222222
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vikramkoka commented on a change in pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
vikramkoka commented on a change in pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#discussion_r565657316
##########
File path: docs/apache-airflow-providers-oracle/connections/oracle.rst
##########
@@ -60,8 +63,35 @@ Extra (optional)
* ``purity`` - one of ``new``, ``self``, ``default``. Specify the session acquired from the pool.
configuration parameter.
- More details on all Oracle connect parameters supported can be found in
- `cx_Oracle documentation <https://cx-oracle.readthedocs.io/en/latest/module.html#cx_Oracle.connect>`_.
+ Connect using Dsn and Sid, Dsn and Service_name, or only Host `(OracleHook.getconn Documentation) <https://airflow.apache.org/docs/apache-airflow-providers-oracle/stable/_modules/airflow/providers/oracle/hooks/oracle.html#OracleHook.get_conn>`_.
+
+ For example:
+
+ .. code-block:: python
+
+ Host = "(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=dbhost.example.com)(PORT=1521))(CONNECT_DATA=(SERVICE_NAME=orclpdb1)))"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Service_name = "orclpdb1"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Sid = "orcl"
+
+
+ More details on all Oracle connect parameters supported can be found in `cx_Oracle documentation
+ <https://cx-oracle.readthedocs.io/en/latest/api_manual/module.html#cx_Oracle.connect>`_.
+
+ Information on creating an Oracle Connection through the web user interface can be found in Airflow's `Managing Connections Documentation
+ <https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html>`_.
Review comment:
:doc:`/howto/connection`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#issuecomment-766321602
Some static checks failing :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mattluudo commented on a change in pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
mattluudo commented on a change in pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#discussion_r564130650
##########
File path: docs/apache-airflow-providers-oracle/connections/oracle.rst
##########
@@ -60,8 +63,35 @@ Extra (optional)
* ``purity`` - one of ``new``, ``self``, ``default``. Specify the session acquired from the pool.
configuration parameter.
- More details on all Oracle connect parameters supported can be found in
- `cx_Oracle documentation <https://cx-oracle.readthedocs.io/en/latest/module.html#cx_Oracle.connect>`_.
+ Connect using Dsn and Sid, Dsn and Service_name, or only Host `(OracleHook.getconn Documentation) <https://airflow.apache.org/docs/apache-airflow-providers-oracle/stable/_modules/airflow/providers/oracle/hooks/oracle.html#OracleHook.get_conn>`_.
+
+ For example:
+
+ .. code-block:: python
+
+ Host = "(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=dbhost.example.com)(PORT=1521))(CONNECT_DATA=(SERVICE_NAME=orclpdb1)))"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Service_name = "orclpdb1"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Sid = "orcl"
+
+
+ More details on all Oracle connect parameters supported can be found in `cx_Oracle documentation
+ <https://cx-oracle.readthedocs.io/en/latest/api_manual/module.html#cx_Oracle.connect>`_.
+
+ Information on creating an Oracle Connection through the web user interface can be found in Airflow's `Managing Connections Documentation
+ <https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html>`_.
Review comment:
You are correct. I will make the change suggested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#discussion_r565664304
##########
File path: docs/apache-airflow-providers-oracle/connections/oracle.rst
##########
@@ -60,8 +63,35 @@ Extra (optional)
* ``purity`` - one of ``new``, ``self``, ``default``. Specify the session acquired from the pool.
configuration parameter.
- More details on all Oracle connect parameters supported can be found in
- `cx_Oracle documentation <https://cx-oracle.readthedocs.io/en/latest/module.html#cx_Oracle.connect>`_.
+ Connect using Dsn and Sid, Dsn and Service_name, or only Host `(OracleHook.getconn Documentation) <https://airflow.apache.org/docs/apache-airflow-providers-oracle/stable/_modules/airflow/providers/oracle/hooks/oracle.html#OracleHook.get_conn>`_.
+
+ For example:
+
+ .. code-block:: python
+
+ Host = "(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=dbhost.example.com)(PORT=1521))(CONNECT_DATA=(SERVICE_NAME=orclpdb1)))"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Service_name = "orclpdb1"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Sid = "orcl"
+
+
+ More details on all Oracle connect parameters supported can be found in `cx_Oracle documentation
+ <https://cx-oracle.readthedocs.io/en/latest/api_manual/module.html#cx_Oracle.connect>`_.
+
+ Information on creating an Oracle Connection through the web user interface can be found in Airflow's `Managing Connections Documentation
+ <https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html>`_.
Review comment:
```suggestion
Information on creating an Oracle Connection through the web user interface can be found in Airflow's :doc:`Managing Connections Documentation <apache-airflow:howto/connection>`.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#discussion_r563611501
##########
File path: docs/apache-airflow-providers-oracle/connections/oracle.rst
##########
@@ -60,8 +63,35 @@ Extra (optional)
* ``purity`` - one of ``new``, ``self``, ``default``. Specify the session acquired from the pool.
configuration parameter.
- More details on all Oracle connect parameters supported can be found in
- `cx_Oracle documentation <https://cx-oracle.readthedocs.io/en/latest/module.html#cx_Oracle.connect>`_.
+ Connect using Dsn and Sid, Dsn and Service_name, or only Host `(OracleHook.getconn Documentation) <https://airflow.apache.org/docs/apache-airflow-providers-oracle/stable/_modules/airflow/providers/oracle/hooks/oracle.html#OracleHook.get_conn>`_.
+
+ For example:
+
+ .. code-block:: python
+
+ Host = "(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=dbhost.example.com)(PORT=1521))(CONNECT_DATA=(SERVICE_NAME=orclpdb1)))"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Service_name = "orclpdb1"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Sid = "orcl"
+
+
+ More details on all Oracle connect parameters supported can be found in `cx_Oracle documentation
+ <https://cx-oracle.readthedocs.io/en/latest/api_manual/module.html#cx_Oracle.connect>`_.
+
+ Information on creating an Oracle Connection through the web user interface can be found in Airflow's `Managing Connections Documentation
+ <https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html>`_.
Review comment:
Do we use http links for internal reference in our docs?
shouldn't this be like the security section [here](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/connection.rst#securing-connections)
So I believe it should be:
:doc:`/howto/connection/index`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mattluudo commented on a change in pull request #13871: Updates Oracle.rst documentation
Posted by GitBox <gi...@apache.org>.
mattluudo commented on a change in pull request #13871:
URL: https://github.com/apache/airflow/pull/13871#discussion_r564312132
##########
File path: docs/apache-airflow-providers-oracle/connections/oracle.rst
##########
@@ -60,8 +63,35 @@ Extra (optional)
* ``purity`` - one of ``new``, ``self``, ``default``. Specify the session acquired from the pool.
configuration parameter.
- More details on all Oracle connect parameters supported can be found in
- `cx_Oracle documentation <https://cx-oracle.readthedocs.io/en/latest/module.html#cx_Oracle.connect>`_.
+ Connect using Dsn and Sid, Dsn and Service_name, or only Host `(OracleHook.getconn Documentation) <https://airflow.apache.org/docs/apache-airflow-providers-oracle/stable/_modules/airflow/providers/oracle/hooks/oracle.html#OracleHook.get_conn>`_.
+
+ For example:
+
+ .. code-block:: python
+
+ Host = "(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=dbhost.example.com)(PORT=1521))(CONNECT_DATA=(SERVICE_NAME=orclpdb1)))"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Service_name = "orclpdb1"
+
+ or
+
+ .. code-block:: python
+
+ Dsn = "dbhost.example.com"
+ Sid = "orcl"
+
+
+ More details on all Oracle connect parameters supported can be found in `cx_Oracle documentation
+ <https://cx-oracle.readthedocs.io/en/latest/api_manual/module.html#cx_Oracle.connect>`_.
+
+ Information on creating an Oracle Connection through the web user interface can be found in Airflow's `Managing Connections Documentation
+ <https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html>`_.
Review comment:
@eladkal
The changes caused this error: WARNING: unknown document: /howto/connection/index. Do you know why the doc link failed?
I reverted it to previous commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org