You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2008/02/28 15:23:58 UTC
[Bug 5839] New: A missing or failed eval rule function can mistakenly count as a rule hit
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5839
Summary: A missing or failed eval rule function can mistakenly
count as a rule hit
Product: Spamassassin
Version: 3.2.4
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P5
Component: Libraries
AssignedTo: dev@spamassassin.apache.org
ReportedBy: Mark.Martinec@ijs.si
A rule specifying an eval function which does not exist (or dies)
does not clear a $result variable, so the rule would count
as a hit if a previous eval rule fired.
The error does get reported as a 'warn:', although few would
notice, but the result is still wrong. E.g.:
[76898] dbg: rules: ran eval rule XXX ======> got hit (1)
[76898] warn: rules: failed to run XXX test, skipping:
[76898] warn: (Can't locate object method "check_xxx"
via package "Mail::SpamAssassin::PerMsgStatus ... )
This can happen if for example a rule from a new version is used
with SpamAssassin code from an earlier version, or if there is a
typo in eval function name in the rule specification, or if
the function dies for some reason.
Problem was reported by Michael Scheidell.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5839] [review] A missing or failed eval rule function can mistakenly count as a rule hit
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5839
Mark.Martinec@ijs.si changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|A missing or failed eval |[review] A missing or failed
|rule function can mistakenly|eval rule function can
|count as a rule hit |mistakenly count as a rule
| |hit
Status Whiteboard| |needs 2 votes for 3.2
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5839] A missing or failed eval rule function can mistakenly count as a rule hit
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5839
Mark.Martinec@ijs.si changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.2.5
------- Additional Comments From Mark.Martinec@ijs.si 2008-02-28 06:27 -------
The fix is trivial:
$ svn -m 'A missing or failed eval rule function can mistakenly count
as a rule hit, bug 5839' ci
Sending lib/Mail/SpamAssassin/Plugin/Check.pm
Committed revision 631982.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5839] [review] A missing or failed eval rule function can mistakenly count as a rule hit
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5839
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes for 3.2 |ready to commit
------- Additional Comments From sidney@sidney.com 2008-02-28 10:44 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5839] [review] A missing or failed eval rule function can mistakenly count as a rule hit
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5839
Mark.Martinec@ijs.si changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From Mark.Martinec@ijs.si 2008-03-02 17:07 -------
Committed to 3.2 as r632902.
(the diff also (unintentionally) removes one comment in Node.pm
which is no longer true; can't hurt)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5839] [review] A missing or failed eval rule function can mistakenly count as a rule hit
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5839
------- Additional Comments From jm@jmason.org 2008-02-28 07:55 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5839] A missing or failed eval rule function can mistakenly count as a rule hit
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5839
------- Additional Comments From Mark.Martinec@ijs.si 2008-02-28 06:34 -------
Created an attachment (id=4266)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4266&action=view)
proposed patch (backported code section from 3.3)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.