You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/11/05 10:59:17 UTC

[GitHub] [superset] kasiazjc opened a new issue #17351: [Explore] when changing column in filters, filters retain previous value or operation

kasiazjc opened a new issue #17351:
URL: https://github.com/apache/superset/issues/17351


   In explore, if we add a filter, save, open to edit and change the column, value or operation stays the same - even though it shouldn't. There are two cases that I was able to find and as I think they are related they are documented in this bug report. 
   
   #### How to reproduce the bug 
   _Operation stays the same_
   
   1. Create a filter in Explore and save it 
   2. Open the filter you created and change the column
   3. See error: operation from the previous column is selected and added to the drop down 
   
   _Value stays the same_
   
   1. Create a filter in Explore and save it 
   2. Open the filter you created and change the column 
   3. Do not change value or operation - value should seem empty
   4. Save filter
   5. See error: Filter retains value from the previous filter that was applied 
   
   ### Expected results
   
   Operations and value should be cleared when user changes the column if the operation or value is not relevant/available
   
   ### Actual results
   
   Operations and/or value are not cleared when user changes the column. Operation is added to the dropdown even though it shouldn't be available. Value seems empty, but the previous one is retained. 
   
   #### Screenshots
   
   _Operation stays the same_
   
   https://user-images.githubusercontent.com/36897697/140500135-7bc02141-8976-4ef1-8e90-9f00f1f18354.mov
   
   _Value stays the same_
   
   https://user-images.githubusercontent.com/36897697/140500184-4a3e0ceb-08de-4803-b439-68986a1d181f.mov
   
   
   
   ### Environment
   
   - browser type and version:
   - superset version: latest master
   - python version: -
   - node.js version: -
   - any feature flags active: - 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #17351: [Explore] when changing column in filters, filters retain previous value or operation

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #17351:
URL: https://github.com/apache/superset/issues/17351#issuecomment-966032097


   @jinghua-qa please add test case thanks! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org