[GitHub] [cordova-plugin-inappbrowser] PDLMobileApps commented on pull request #755: (android) Removed waitForBeforeload flag as it prevents beforeLoad from being called on every GET request

[GitBox <gi...@apache.org>]

PDLMobileApps commented on pull request #755:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/755#issuecomment-702349120


   > waitForBeforeload is necessary. I think it prevent duplicate event.
   > 
   > for fix problem you maybe want correct it instead of remove.
   > 
   > I have found same problem before and fixed by correct it when onPageFinished. Real problem is when load error it not reset waitForBeforeload.
   > 
   > Could you please check [commit](https://github.com/stionic/cordova-plugin-inappbrowser/commit/d2ddbfe37ceceb9ace56007c282902e765e41076)?
   
   We have been using the change in this PR in our app in the Google Play Store for almost two month (500k installs). We have no reports of issues with beforeLoad which is called a lot when the customer uses the app. So, if waitForBeforeload is really necessary, I would expect a completely different situation.
   
   By the way, no one has been able to provide a good explanation on why it's needed. On the other hand, if you have in the code, beforeLoad only happens every other request, which is definitely wrong. That has been reported more than once by many people.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org