You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/11/16 21:18:01 UTC
[GitHub] [calcite] sdreynolds commented on a change in pull request #1589:
[CALCITE-3508] Strengthen outer Join to inner if it is under a Filter that
discards null values
sdreynolds commented on a change in pull request #1589: [CALCITE-3508] Strengthen outer Join to inner if it is under a Filter that discards null values
URL: https://github.com/apache/calcite/pull/1589#discussion_r347107248
##########
File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
##########
@@ -5452,19 +5458,25 @@ on d.deptno = e.deptno where d.deptno > 7 and e.deptno > 9]]>
<Resource name="planBefore">
<![CDATA[
LogicalProject(EXPR$0=[1])
- LogicalFilter(condition=[AND(>($7, 7), >($16, 9))])
Review comment:
This changes:
```sql
select 1 from sales.emp d full outer join sales.emp e
on d.deptno = e.deptno where d.deptno > 7 and e.deptno > 9
```
into
```sql
select 1 from sales.emp d inner join sales.emp e
on d.deptno = e.deptno where d.deptno > 7 and e.deptno > 9
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services