You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/11/20 01:46:41 UTC
[GitHub] [mynewt-mcumgr] JordanYates opened a new issue #101: Zephyr: "os reset" unnecessary work item
JordanYates opened a new issue #101:
URL: https://github.com/apache/mynewt-mcumgr/issues/101
The zephyr implementation of `os_mgmt_impl_reset` triggers a timer to defer the reset by a small time duration.
The timer expiry function then submits a workqueue item so that the reset is run from the system workqueue.
Timer callbacks are already run from the system workqueue. https://docs.zephyrproject.org/latest/reference/kernel/timing/timers.html#using-a-timer-expiry-function)
The additional workqueue item can therefore be removed, with `sys_reboot` being called directly from the timer expiry function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] sw commented on issue #101: Zephyr: "os reset" unnecessary work item
Posted by GitBox <gi...@apache.org>.
sw commented on issue #101:
URL: https://github.com/apache/mynewt-mcumgr/issues/101#issuecomment-918936817
> Timer callbacks are already run from the system workqueue.
That's not what the documentation says, is it? Has that changed since last year?
The function could probably be changed to use a delayable work item instead of the timer and regular work item.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] JordanYates commented on issue #101: Zephyr: "os reset" unnecessary work item
Posted by GitBox <gi...@apache.org>.
JordanYates commented on issue #101:
URL: https://github.com/apache/mynewt-mcumgr/issues/101#issuecomment-918975772
Hmm, it doesn't look like it has changed, and I can't remember the context of this from last year.
It could have just been confusion around why bother deferring the reboot to the workqueue thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] JordanYates closed issue #101: Zephyr: "os reset" unnecessary work item
Posted by GitBox <gi...@apache.org>.
JordanYates closed issue #101:
URL: https://github.com/apache/mynewt-mcumgr/issues/101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org