You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/08/14 01:32:47 UTC
Review Request 24677: Add Docker::pull
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24677/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Jie Yu.
Repository: mesos-git
Description
-------
Added Docker pull(). BenH already has a patch and I'm taking his and adding inspect call into pull.
Diffs
-----
src/docker/docker.hpp 98b2d60
src/docker/docker.cpp 1cba381
Diff: https://reviews.apache.org/r/24677/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 24677: Add Docker::pull
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24677/#review50568
-----------------------------------------------------------
Bad patch!
Reviews applied: [24677]
Failed command: git apply --index 24677.patch
Error:
error: patch failed: src/docker/docker.hpp:82
error: src/docker/docker.hpp: patch does not apply
error: patch failed: src/docker/docker.cpp:209
error: src/docker/docker.cpp: patch does not apply
- Mesos ReviewBot
On Aug. 13, 2014, 11:32 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24677/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 11:32 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added Docker pull(). BenH already has a patch and I'm taking his and adding inspect call into pull.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 98b2d60
> src/docker/docker.cpp 1cba381
>
> Diff: https://reviews.apache.org/r/24677/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 24677: Add Docker::pull
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24677/#review50532
-----------------------------------------------------------
Ship it!
src/docker/docker.cpp
<https://reviews.apache.org/r/24677/#comment88395>
The image here might come from end user. So for security concern, we should use the argv version to prevent shell injection. You don't need to address that in this patch, but we should address that before releasing.
For example, what if
image == "&& rm -rf / &&"
src/docker/docker.cpp
<https://reviews.apache.org/r/24677/#comment88396>
Ditto.
- Jie Yu
On Aug. 13, 2014, 11:32 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24677/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 11:32 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added Docker pull(). BenH already has a patch and I'm taking his and adding inspect call into pull.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 98b2d60
> src/docker/docker.cpp 1cba381
>
> Diff: https://reviews.apache.org/r/24677/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>