You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/01 18:08:04 UTC

[GitHub] zhreshold commented on a change in pull request #13067: ONNX export: Set np.array type to float32

zhreshold commented on a change in pull request #13067: ONNX export: Set np.array type to float32
URL: https://github.com/apache/incubator-mxnet/pull/13067#discussion_r230141724
 
 

 ##########
 File path: python/mxnet/contrib/onnx/mx2onnx/_op_translations.py
 ##########
 @@ -1840,7 +1840,7 @@ def convert_reshape(node, **kwargs):
     output_shape_list = convert_string_to_list(attrs["shape"])
 
     initializer = kwargs["initializer"]
-    output_shape_np = np.array(output_shape_list)
+    output_shape_np = np.array(output_shape_list, dtype='float32')
 
 Review comment:
   don't use float for shape

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services