[GitHub] [hudi] danny0405 commented on a diff in pull request #6923: [HUDI-5010] Fix flink hive catalog external config not work

[GitBox <gi...@apache.org>]

danny0405 commented on code in PR #6923:
URL: https://github.com/apache/hudi/pull/6923#discussion_r992927365


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieHiveCatalog.java:
##########
@@ -117,21 +117,24 @@ public class HoodieHiveCatalog extends AbstractCatalog {
 
   // optional catalog base path: used for db/table path inference.
   private final String catalogPath;
+  private final boolean external;
 
-  public HoodieHiveCatalog(String catalogName, String catalogPath, String defaultDatabase, String hiveConfDir) {
-    this(catalogName, catalogPath, defaultDatabase, HoodieCatalogUtil.createHiveConf(hiveConfDir), false);
+  public HoodieHiveCatalog(String catalogName, String catalogPath, String defaultDatabase, String hiveConfDir, boolean external) {
+    this(catalogName, catalogPath, defaultDatabase, HoodieCatalogUtil.createHiveConf(hiveConfDir), false, external);
   }
 
   public HoodieHiveCatalog(
       String catalogName,
       String catalogPath,
       String defaultDatabase,
       HiveConf hiveConf,
-      boolean allowEmbedded) {
+      boolean allowEmbedded,
+      boolean external) {

Review Comment:
   Nice catch, can we put the param `external` in front of `allowEmbedded` and can we add a test case in `TestHoodieHiveCatalog`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org