You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by jd...@apache.org on 2016/04/04 22:36:47 UTC
[12/50] [abbrv] hive git commit: HIVE-13151 : Clean up UGI objects in
FileSystem cache for transactions, ADDENDUM (Wei Zheng,
reviewed by Eugene Koifman)
HIVE-13151 : Clean up UGI objects in FileSystem cache for transactions, ADDENDUM (Wei Zheng, reviewed by Eugene Koifman)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/4fabd038
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/4fabd038
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/4fabd038
Branch: refs/heads/llap
Commit: 4fabd038cf64b906a89726805958c43b97194291
Parents: 6bfec2e
Author: Wei Zheng <we...@apache.org>
Authored: Thu Mar 24 22:18:32 2016 -0700
Committer: Wei Zheng <we...@apache.org>
Committed: Thu Mar 24 22:18:32 2016 -0700
----------------------------------------------------------------------
.../java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java | 5 +++--
.../java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java | 4 ++--
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java | 5 +++--
3 files changed, 8 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hive/blob/4fabd038/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
----------------------------------------------------------------------
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java b/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
index 4c31a49..23b1b7f 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
@@ -275,8 +275,9 @@ public class Cleaner extends CompactorThread {
try {
FileSystem.closeAllForUGI(ugi);
} catch (IOException exception) {
- LOG.error("Could not clean up file-system handles for UGI: " + ugi, exception + " for " +
- ci.getFullPartitionName()); }
+ LOG.error("Could not clean up file-system handles for UGI: " + ugi + " for " +
+ ci.getFullPartitionName(), exception);
+ }
}
txnHandler.markCleaned(ci);
} catch (Exception e) {
http://git-wip-us.apache.org/repos/asf/hive/blob/4fabd038/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
----------------------------------------------------------------------
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java b/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
index 98ebf53..abbe5d4 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
@@ -235,8 +235,8 @@ public class Initiator extends CompactorThread {
try {
FileSystem.closeAllForUGI(ugi);
} catch (IOException exception) {
- LOG.error("Could not clean up file-system handles for UGI: " + ugi, exception + " for " +
- ci.getFullPartitionName());
+ LOG.error("Could not clean up file-system handles for UGI: " + ugi + " for " +
+ ci.getFullPartitionName(), exception);
}
return compactionType;
}
http://git-wip-us.apache.org/repos/asf/hive/blob/4fabd038/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
----------------------------------------------------------------------
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java b/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
index e21ca27..6238e2b 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
@@ -175,8 +175,9 @@ public class Worker extends CompactorThread {
try {
FileSystem.closeAllForUGI(ugi);
} catch (IOException exception) {
- LOG.error("Could not clean up file-system handles for UGI: " + ugi, exception + " for " +
- ci.getFullPartitionName()); }
+ LOG.error("Could not clean up file-system handles for UGI: " + ugi + " for " +
+ ci.getFullPartitionName(), exception);
+ }
}
txnHandler.markCompacted(ci);
} catch (Exception e) {