You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2015/07/31 20:50:04 UTC

[jira] [Commented] (SOLR-7854) Remove ZkStateReader.updateClusterState(false)

    [ https://issues.apache.org/jira/browse/SOLR-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649644#comment-14649644 ] 

Mark Miller commented on SOLR-7854:
-----------------------------------

updateClusterState(false) use to be used a lot to prevent silly rapid updates faster than was useful. Long ago, someone removed it's use but never cleaned it up fully.

> Remove ZkStateReader.updateClusterState(false)
> ----------------------------------------------
>
>                 Key: SOLR-7854
>                 URL: https://issues.apache.org/jira/browse/SOLR-7854
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>    Affects Versions: 5.2.1
>            Reporter: Scott Blum
>            Priority: Minor
>              Labels: easyfix, newbie
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> `updateClusterState(false)` as far as I can tell has zero callers.  It's super pointless anyway, because `updateClusterState(true)` is being used mostly from test code and in places where someone is trying to force a reload from ZK (for whatever reason).  There's no point in asking for a deferred update when ZkStateReader is already going to keep itself in sync anyway.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org