You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by se...@apache.org on 2022/06/12 16:20:01 UTC
[directory-studio] branch DIRSTUDIO-1298-add-address-editor-ui-test-2 created (now 62706d3c9)
This is an automated email from the ASF dual-hosted git repository.
seelmann pushed a change to branch DIRSTUDIO-1298-add-address-editor-ui-test-2
in repository https://gitbox.apache.org/repos/asf/directory-studio.git
at 62706d3c9 DIRSTUDIO-1298: Update address editor UI test
This branch includes the following new commits:
new 62706d3c9 DIRSTUDIO-1298: Update address editor UI test
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[directory-studio] 01/01: DIRSTUDIO-1298: Update address editor UI test
Posted by se...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
seelmann pushed a commit to branch DIRSTUDIO-1298-add-address-editor-ui-test-2
in repository https://gitbox.apache.org/repos/asf/directory-studio.git
commit 62706d3c9c9d70910918b2ef3229072d6f1070ae
Author: Stefan Seelmann <ma...@stefan-seelmann.de>
AuthorDate: Sun Jun 12 18:19:48 2022 +0200
DIRSTUDIO-1298: Update address editor UI test
---
.../studio/test/integration/ui/EntryEditorTest.java | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/EntryEditorTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/EntryEditorTest.java
index 7c2b53ca7..1ed2ca7c1 100644
--- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/EntryEditorTest.java
+++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/EntryEditorTest.java
@@ -569,7 +569,7 @@ public class EntryEditorTest extends AbstractTestBase
/**
- * DIRSTUDIO-1298: The RFC 4517 Postal Address value editor en-/decoding is incomplete
+ * Test for the postal address value editor, with an example from DIRSTUDIO-1298 to verify encoding/decoding of special characters.
*/
@ParameterizedTest
@LdapServersSource
@@ -611,28 +611,23 @@ public class EntryEditorTest extends AbstractTestBase
"1234 Main St., Anytown, CA 12345, USA" );
assertTrue( addressEditorDialogBot.isVisible() );
assertEquals( "1234 Main St.\nAnytown, CA 12345\nUSA", addressEditorDialogBot.getText() );
- // TODO: $1,000,000 Sweepstakes
- addressEditorDialogBot.setText( "1,000,000 Sweepstakes\nPO Box 1000000\nAnytown, CA 12345\nUSA" );
+ addressEditorDialogBot.setText( "$1,000,000 Sweepstakes\nPO Box 1000000\nAnytown, CA 12345\nUSA" );
addressEditorDialogBot.clickOkButton();
assertEquals( 9, entryEditorBot.getAttributeValues().size() );
assertFalse( entryEditorBot.getAttributeValues()
.contains( "postalAddress: 1234 Main St., Anytown, CA 12345, USA" ) );
assertTrue( entryEditorBot.getAttributeValues()
- // TODO: $1,000,000 Sweepstakes
- .contains( "postalAddress: 1,000,000 Sweepstakes, PO Box 1000000, Anytown, CA 12345, USA" ) );
+ .contains( "postalAddress: $1,000,000 Sweepstakes, PO Box 1000000, Anytown, CA 12345, USA" ) );
modificationLogsViewBot
.waitForText( "delete: postalAddress\npostalAddress: 1234 Main St.$Anytown, CA 12345$USA" );
modificationLogsViewBot.waitForText(
- // TODO: $1,000,000 Sweepstakes
- "add: postalAddress\npostalAddress: 1,000,000 Sweepstakes$PO Box 1000000$Anytown, CA 12345$USA" );
+ "add: postalAddress\npostalAddress: \\241,000,000 Sweepstakes$PO Box 1000000$Anytown, CA 12345$USA" );
// verify value is correctly decoded
- // TODO: $1,000,000 Sweepstakes
addressEditorDialogBot = entryEditorBot.editValueExpectingAddressEditor( "postalAddress",
- "1,000,000 Sweepstakes, PO Box 1000000, Anytown, CA 12345, USA" );
+ "$1,000,000 Sweepstakes, PO Box 1000000, Anytown, CA 12345, USA" );
assertTrue( addressEditorDialogBot.isVisible() );
- // TODO: $1,000,000 Sweepstakes
- assertEquals( "1,000,000 Sweepstakes\nPO Box 1000000\nAnytown, CA 12345\nUSA",
+ assertEquals( "$1,000,000 Sweepstakes\nPO Box 1000000\nAnytown, CA 12345\nUSA",
addressEditorDialogBot.getText() );
addressEditorDialogBot.clickCancelButton();
}