You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kfaraz (via GitHub)" <gi...@apache.org> on 2025/05/12 15:17:31 UTC
[PR] Allow use of centralized datasource schema and segment metadata cache together (druid)
kfaraz opened a new pull request, #17996:
URL: https://github.com/apache/druid/pull/17996
### Description
#17935 enables use of `HeapMemorySegmentMetadataCache` on the Coordinator.
But it cannot be used in conjunction with centralized datasource schema (i.e. `SegmentSchemaCache`)
This patch supports usage of both features on the Coordinator together.
### Changes
- Make `SegmentSchemaCache` a dependency of `HeapMemorySegmentMetadataCache`
- Always bind `SegmentSchemaCache` on all services since it is now a dependency of
`HeapMemorySegmentMetadataCache`
- Poll schemas in `HeapMemorySegmentMetadataCache` and update `SegmentSchemaCache`
- Emit relevant metrics
### Pending items
- Unit tests
- Enable ITs to use both features
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Allow use of centralized datasource schema and segment metadata cache together (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on PR #17996:
URL: https://github.com/apache/druid/pull/17996#issuecomment-2888742618
@gianm , I have had to fix up the delta sync logic since there were some bugs with the previous approach.
The sync for schemas now resembles the logic employed for used segments. It works as follows:
- Full sync
- Fetch all schemas marked as "used" in the metadata store
- Delta sync
- Fetch only fingerprints for all schemas marked as "used" in the metadata store
- Remove entries from cache if they are not present in the metadata store anymore
- Fetch payloads only for fingerprints which are not already present in the metadata store
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Allow use of centralized datasource schema and segment metadata cache together (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz merged PR #17996:
URL: https://github.com/apache/druid/pull/17996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org