[GitHub] [kafka] splett2 commented on pull request #11454: KAFKA-13341: Quotas are not applied to requests with null clientId

[GitBox <gi...@apache.org>]

splett2 commented on pull request #11454:
URL: https://github.com/apache/kafka/pull/11454#issuecomment-955601970


   thanks. The phenomenon I was describing was addressed by #11385.
   Null client IDs were being improperly propagated up from the RPC layer to the broker server-side handling.
   
   I didn't notice that the `ClientQuotaManager` code does not handle empty clientId.
   I didn't take a deep look at the client quotas hierarchy spec, but I'm not sure that we would want to translate an `ANONYMOUS` user principal to empty. That seems like a change in behavior. 
   
   One thing I would note, it seems weird that if we have both an empty user and empty clientId, we apply `/config/clients/<default>`. For instance, I don't see why we would apply the default clientId quota rather than a default user principal quota. It seems like an arbitrary choice either way.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org