You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "PDGGK (via GitHub)" <gi...@apache.org> on 2026/09/28 07:47:28 UTC

[PR] Continue closing storage data sources after a close failure [shardingsphere]

PDGGK opened a new pull request, #39988:
URL: https://github.com/apache/shardingsphere/pull/39988

   Purpose:
   
   `ShardingSphereDataSource.close()` currently stops at the first storage data source whose `close()` fails. With multiple storage units, that leaves later pools open and skips the remaining storage-data-source cleanup.
   
   Changes:
   - preserve the first `SQLException` while continuing to close the remaining storage data sources
   - attach later storage-data-source close failures as suppressed exceptions
   - keep the existing `ContextManager.close()` path and unchecked-exception behavior
   - add regression coverage for continued cleanup and suppressed failures
   
   Tests:
   - on the original close sequence, the 2 new regression cases fail for the expected cleanup reasons
   - `./mvnw -B -pl jdbc -am test -Dtest='ShardingSphereDataSourceTest' -Dsurefire.failIfNoSpecifiedTests=false -Dcheckstyle.skip -Dspotless.check.skip=true -Drat.skip -Djacoco.skip`
   - `./mvnw -B -Pcheck -pl jdbc checkstyle:check spotless:check -DskipTests -Drat.skip -Djacoco.skip`
   
   No public API change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Continue closing storage data sources after a close failure [shardingsphere]

Posted by "PDGGK (via GitHub)" <gi...@apache.org>.
PDGGK commented on PR #39988:
URL: https://github.com/apache/shardingsphere/pull/39988#issuecomment-5966472664

   Both constructor calls are now on single lines.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Continue closing storage data sources after a close failure [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39988:
URL: https://github.com/apache/shardingsphere/pull/39988


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org