You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/25 11:09:01 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #8210:
[FLINK-12203] Refactor ResultPartitionManager to break tie with Task
azagrebin commented on a change in pull request #8210: [FLINK-12203] Refactor ResultPartitionManager to break tie with Task
URL: https://github.com/apache/flink/pull/8210#discussion_r278502434
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -667,11 +668,9 @@ private void stopTaskExecutorServices() throws Exception {
}
@Override
- public void failPartition(ExecutionAttemptID executionAttemptID) {
- log.info("Discarding the results produced by task execution {}.", executionAttemptID);
Review comment:
I was thinking about it, the problem here is that previously it happened per task. Now, it gets a list of partitions without assumption that it is per task. JM will still log it in `sendReleaseIntermediateResultPartitionsRpcCall`. If more verbose mode is needed, debug level will enable per partition logging in `ResultPartitionManager.releasePartition` in TM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services