You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/01/09 00:06:29 UTC
Review Request 16741: Converting py source dist versions to upper() for
consistency with java side.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16741/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
Our python distributions use lower case version format, whereas java side uses upper case (which is maven compliant).
Diffs
-----
src/main/python/apache/aurora/client/BUILD 510297084a8fb14154aa0074f4e61a14b5837a8c
src/main/python/apache/aurora/common/BUILD 9da66aa219363f8c68308e0f197d2705675f1ac7
src/main/python/apache/aurora/config/BUILD 58a0ab10eb0ac8bca5ed92f7a1fe6c86c5842fe6
src/main/python/apache/aurora/executor/BUILD 8a3413be3d91f24dec84d70bd0eee8d6d2482d34
src/main/python/apache/thermos/BUILD 81a0c403dc9745b6f9285a66155d49c4eec4b0f1
src/main/python/apache/thermos/common/BUILD 006147ca8aff6eccafdafd0f0e4fdd2d82fcf2f5
src/main/python/apache/thermos/config/BUILD 084efed17b1ad93882ec777fb7a7223574940ce6
src/main/python/apache/thermos/core/BUILD 0515e034ef276939af69acb88db0ab5ce2b16041
src/main/python/apache/thermos/monitoring/BUILD f5b1b0efcd553227b3dded63c4c60a43bae4f835
src/main/python/apache/thermos/observer/BUILD 8a27396994b2fbfbe10c6b050351ab465f310b5c
src/main/thrift/org/apache/aurora/gen/BUILD 0de6958e96479dfc60ed366af8fde58d82992da0
src/main/thrift/org/apache/thermos/BUILD 24411547823cdd712729168f96603d29119573be
Diff: https://reviews.apache.org/r/16741/diff/
Testing
-------
local publishing
Thanks,
Maxim Khutornenko
Re: Review Request 16741: Converting py source dist versions to upper() for
consistency with java side.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16741/#review31923
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Jan. 8, 2014, 11:06 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16741/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 11:06 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Our python distributions use lower case version format, whereas java side uses upper case (which is maven compliant).
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/BUILD 510297084a8fb14154aa0074f4e61a14b5837a8c
> src/main/python/apache/aurora/common/BUILD 9da66aa219363f8c68308e0f197d2705675f1ac7
> src/main/python/apache/aurora/config/BUILD 58a0ab10eb0ac8bca5ed92f7a1fe6c86c5842fe6
> src/main/python/apache/aurora/executor/BUILD 8a3413be3d91f24dec84d70bd0eee8d6d2482d34
> src/main/python/apache/thermos/BUILD 81a0c403dc9745b6f9285a66155d49c4eec4b0f1
> src/main/python/apache/thermos/common/BUILD 006147ca8aff6eccafdafd0f0e4fdd2d82fcf2f5
> src/main/python/apache/thermos/config/BUILD 084efed17b1ad93882ec777fb7a7223574940ce6
> src/main/python/apache/thermos/core/BUILD 0515e034ef276939af69acb88db0ab5ce2b16041
> src/main/python/apache/thermos/monitoring/BUILD f5b1b0efcd553227b3dded63c4c60a43bae4f835
> src/main/python/apache/thermos/observer/BUILD 8a27396994b2fbfbe10c6b050351ab465f310b5c
> src/main/thrift/org/apache/aurora/gen/BUILD 0de6958e96479dfc60ed366af8fde58d82992da0
> src/main/thrift/org/apache/thermos/BUILD 24411547823cdd712729168f96603d29119573be
>
> Diff: https://reviews.apache.org/r/16741/diff/
>
>
> Testing
> -------
>
> local publishing
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 16741: Converting py source dist versions to upper() for
consistency with java side.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16741/#review31927
-----------------------------------------------------------
Thanks. Pushed.
- Maxim Khutornenko
On Jan. 8, 2014, 11:06 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16741/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 11:06 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Our python distributions use lower case version format, whereas java side uses upper case (which is maven compliant).
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/BUILD 510297084a8fb14154aa0074f4e61a14b5837a8c
> src/main/python/apache/aurora/common/BUILD 9da66aa219363f8c68308e0f197d2705675f1ac7
> src/main/python/apache/aurora/config/BUILD 58a0ab10eb0ac8bca5ed92f7a1fe6c86c5842fe6
> src/main/python/apache/aurora/executor/BUILD 8a3413be3d91f24dec84d70bd0eee8d6d2482d34
> src/main/python/apache/thermos/BUILD 81a0c403dc9745b6f9285a66155d49c4eec4b0f1
> src/main/python/apache/thermos/common/BUILD 006147ca8aff6eccafdafd0f0e4fdd2d82fcf2f5
> src/main/python/apache/thermos/config/BUILD 084efed17b1ad93882ec777fb7a7223574940ce6
> src/main/python/apache/thermos/core/BUILD 0515e034ef276939af69acb88db0ab5ce2b16041
> src/main/python/apache/thermos/monitoring/BUILD f5b1b0efcd553227b3dded63c4c60a43bae4f835
> src/main/python/apache/thermos/observer/BUILD 8a27396994b2fbfbe10c6b050351ab465f310b5c
> src/main/thrift/org/apache/aurora/gen/BUILD 0de6958e96479dfc60ed366af8fde58d82992da0
> src/main/thrift/org/apache/thermos/BUILD 24411547823cdd712729168f96603d29119573be
>
> Diff: https://reviews.apache.org/r/16741/diff/
>
>
> Testing
> -------
>
> local publishing
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 16741: Converting py source dist versions to upper() for
consistency with java side.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16741/#review31823
-----------------------------------------------------------
Ping.
- Maxim Khutornenko
On Jan. 8, 2014, 11:06 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16741/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 11:06 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Our python distributions use lower case version format, whereas java side uses upper case (which is maven compliant).
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/BUILD 510297084a8fb14154aa0074f4e61a14b5837a8c
> src/main/python/apache/aurora/common/BUILD 9da66aa219363f8c68308e0f197d2705675f1ac7
> src/main/python/apache/aurora/config/BUILD 58a0ab10eb0ac8bca5ed92f7a1fe6c86c5842fe6
> src/main/python/apache/aurora/executor/BUILD 8a3413be3d91f24dec84d70bd0eee8d6d2482d34
> src/main/python/apache/thermos/BUILD 81a0c403dc9745b6f9285a66155d49c4eec4b0f1
> src/main/python/apache/thermos/common/BUILD 006147ca8aff6eccafdafd0f0e4fdd2d82fcf2f5
> src/main/python/apache/thermos/config/BUILD 084efed17b1ad93882ec777fb7a7223574940ce6
> src/main/python/apache/thermos/core/BUILD 0515e034ef276939af69acb88db0ab5ce2b16041
> src/main/python/apache/thermos/monitoring/BUILD f5b1b0efcd553227b3dded63c4c60a43bae4f835
> src/main/python/apache/thermos/observer/BUILD 8a27396994b2fbfbe10c6b050351ab465f310b5c
> src/main/thrift/org/apache/aurora/gen/BUILD 0de6958e96479dfc60ed366af8fde58d82992da0
> src/main/thrift/org/apache/thermos/BUILD 24411547823cdd712729168f96603d29119573be
>
> Diff: https://reviews.apache.org/r/16741/diff/
>
>
> Testing
> -------
>
> local publishing
>
>
> Thanks,
>
> Maxim Khutornenko
>
>