You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by ac...@apache.org on 2017/08/29 08:35:32 UTC
[2/2] camel git commit: CAMEL-11716: Fix sql-stored to return result
from function call
CAMEL-11716: Fix sql-stored to return result from function call
Conflicts:
components/camel-sql/src/main/java/org/apache/camel/component/sql/stored/TemplateStoredProcedure.java
Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/6a96755a
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/6a96755a
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/6a96755a
Branch: refs/heads/camel-2.19.x
Commit: 6a96755a2dda59deceb8f6a044bf22234266bbe9
Parents: d9a5738
Author: Tomas Turek <tt...@redhat.com>
Authored: Wed Aug 23 13:28:32 2017 +0200
Committer: Andrea Cosentino <an...@gmail.com>
Committed: Tue Aug 29 10:35:09 2017 +0200
----------------------------------------------------------------------
.../sql/stored/TemplateStoredProcedure.java | 1 -
.../stored/CallableStatementWrapperTest.java | 22 +++++++++++++
.../sql/stored/TestStoredFunction.java | 34 ++++++++++++++++++++
.../test/resources/sql/storedProcedureTest.sql | 7 ++++
4 files changed, 63 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/camel/blob/6a96755a/components/camel-sql/src/main/java/org/apache/camel/component/sql/stored/TemplateStoredProcedure.java
----------------------------------------------------------------------
diff --git a/components/camel-sql/src/main/java/org/apache/camel/component/sql/stored/TemplateStoredProcedure.java b/components/camel-sql/src/main/java/org/apache/camel/component/sql/stored/TemplateStoredProcedure.java
index c1bec3c..7ced2a3 100644
--- a/components/camel-sql/src/main/java/org/apache/camel/component/sql/stored/TemplateStoredProcedure.java
+++ b/components/camel-sql/src/main/java/org/apache/camel/component/sql/stored/TemplateStoredProcedure.java
@@ -56,7 +56,6 @@ public class TemplateStoredProcedure extends StoredProcedure {
} else if (parameter instanceof OutParameter) {
OutParameter outParameter = (OutParameter) parameter;
declareParameter(new SqlOutParameter(outParameter.getOutValueMapKey(), outParameter.getSqlType()));
- setFunction(false);
}
}
http://git-wip-us.apache.org/repos/asf/camel/blob/6a96755a/components/camel-sql/src/test/java/org/apache/camel/component/sql/stored/CallableStatementWrapperTest.java
----------------------------------------------------------------------
diff --git a/components/camel-sql/src/test/java/org/apache/camel/component/sql/stored/CallableStatementWrapperTest.java b/components/camel-sql/src/test/java/org/apache/camel/component/sql/stored/CallableStatementWrapperTest.java
index 0bec974..1650c5b 100644
--- a/components/camel-sql/src/test/java/org/apache/camel/component/sql/stored/CallableStatementWrapperTest.java
+++ b/components/camel-sql/src/test/java/org/apache/camel/component/sql/stored/CallableStatementWrapperTest.java
@@ -71,6 +71,28 @@ public class CallableStatementWrapperTest extends CamelTestSupport {
}
@Test
+ public void shouldExecuteStoredFunction() throws Exception {
+ CallableStatementWrapperFactory factory = new CallableStatementWrapperFactory(jdbcTemplate, templateParser, true);
+
+ CallableStatementWrapper wrapper = new CallableStatementWrapper("SUBNUMBERS_FUNCTION"
+ + "(OUT INTEGER resultofsub, INTEGER ${header.v1},INTEGER ${header.v2})", factory);
+
+ final Exchange exchange = createExchangeWithBody(null);
+ exchange.getIn().setHeader("v1", 1);
+ exchange.getIn().setHeader("v2", 2);
+
+ wrapper.call(new WrapperExecuteCallback() {
+ @Override
+ public void execute(StatementWrapper statementWrapper) throws SQLException, DataAccessException {
+ statementWrapper.populateStatement(null, exchange);
+
+ Map resultOfQuery = (Map) statementWrapper.executeStatement();
+ Assert.assertEquals(-1, resultOfQuery.get("resultofsub"));
+ }
+ });
+ }
+
+ @Test
public void shouldExecuteNilacidProcedure() throws Exception {
CallableStatementWrapper wrapper = new CallableStatementWrapper("NILADIC()", factory);
http://git-wip-us.apache.org/repos/asf/camel/blob/6a96755a/components/camel-sql/src/test/java/org/apache/camel/component/sql/stored/TestStoredFunction.java
----------------------------------------------------------------------
diff --git a/components/camel-sql/src/test/java/org/apache/camel/component/sql/stored/TestStoredFunction.java b/components/camel-sql/src/test/java/org/apache/camel/component/sql/stored/TestStoredFunction.java
new file mode 100644
index 0000000..a66e2ce
--- /dev/null
+++ b/components/camel-sql/src/test/java/org/apache/camel/component/sql/stored/TestStoredFunction.java
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.sql.stored;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public final class TestStoredFunction {
+
+ private static final Logger LOG = LoggerFactory.getLogger(TestStoredFunction.class);
+
+
+ private TestStoredFunction() {
+ }
+
+ public static int subnumbers(int val1, int val2) {
+ LOG.info("calling subnumbers:{} - {}", val1, val2);
+ return val1 - val2;
+ }
+}
http://git-wip-us.apache.org/repos/asf/camel/blob/6a96755a/components/camel-sql/src/test/resources/sql/storedProcedureTest.sql
----------------------------------------------------------------------
diff --git a/components/camel-sql/src/test/resources/sql/storedProcedureTest.sql b/components/camel-sql/src/test/resources/sql/storedProcedureTest.sql
index 108c2e1..a1a0750 100644
--- a/components/camel-sql/src/test/resources/sql/storedProcedureTest.sql
+++ b/components/camel-sql/src/test/resources/sql/storedProcedureTest.sql
@@ -32,3 +32,10 @@ CREATE PROCEDURE BATCHFN(VALUE1 CHAR(10))
LANGUAGE JAVA
EXTERNAL NAME
'org.apache.camel.component.sql.stored.TestStoredProcedure.batchfn';
+
+CREATE FUNCTION SUBNUMBERS_FUNCTION(VALUE1 INTEGER, VALUE2 INTEGER)
+ RETURNS INTEGER
+ PARAMETER STYLE JAVA
+ LANGUAGE JAVA
+ EXTERNAL NAME
+'org.apache.camel.component.sql.stored.TestStoredFunction.subnumbers';