You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mandeep Chadha <ma...@yahoo.com> on 2015/10/06 19:59:25 UTC
Review Request 39056: Fix for Mesos master crash due to check failure.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39056/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-3552
https://issues.apache.org/jira/browse/MESOS-3552
Repository: mesos
Description
-------
Check failed due to double comparison : MESOS-3552.
Diffs
-----
src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1
src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e
Diff: https://reviews.apache.org/r/39056/diff/
Testing
-------
Added unit test.
make check successful.
Thanks,
Mandeep Chadha
Re: Review Request 39056: Fix for Mesos master crash due to check
failure.
Posted by Mandeep Chadha <ma...@yahoo.com>.
> On Oct. 6, 2015, 6:34 p.m., Neil Conway wrote:
> > src/common/resources.cpp, line 874
> > <https://reviews.apache.org/r/39056/diff/1/?file=1091951#file1091951line874>
> >
> > This change should also be applied to Resources::apply() in src/v1/resources.cpp
Thanks Neil.
- Mandeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39056/#review101674
-----------------------------------------------------------
On Oct. 6, 2015, 9:33 p.m., Mandeep Chadha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39056/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 9:33 p.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Bugs: MESOS-3552
> https://issues.apache.org/jira/browse/MESOS-3552
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Check failed due to double comparison : MESOS-3552.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1
> src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e
> src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39
>
> Diff: https://reviews.apache.org/r/39056/diff/
>
>
> Testing
> -------
>
> Added unit test.
> make check successful.
>
>
> Thanks,
>
> Mandeep Chadha
>
>
Re: Review Request 39056: Fix for Mesos master crash due to check
failure.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39056/#review101674
-----------------------------------------------------------
src/common/resources.cpp (line 870)
<https://reviews.apache.org/r/39056/#comment159127>
This change should also be applied to Resources::apply() in src/v1/resources.cpp
src/common/resources.cpp (line 871)
<https://reviews.apache.org/r/39056/#comment159132>
Capitalize "check"; also, maybe include a brief explanation of why we might see some error in the floating point calculation.
src/common/resources.cpp (line 872)
<https://reviews.apache.org/r/39056/#comment159129>
Should be "constexpr", maybe "static" too.
src/tests/reservation_tests.cpp (line 175)
<https://reviews.apache.org/r/39056/#comment159131>
I think the comment here should explain why using a double value is relevant.
src/tests/reservation_tests.cpp (line 245)
<https://reviews.apache.org/r/39056/#comment159128>
Whitespace/capitalization.
- Neil Conway
On Oct. 6, 2015, 5:59 p.m., Mandeep Chadha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39056/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 5:59 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3552
> https://issues.apache.org/jira/browse/MESOS-3552
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Check failed due to double comparison : MESOS-3552.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1
> src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e
>
> Diff: https://reviews.apache.org/r/39056/diff/
>
>
> Testing
> -------
>
> Added unit test.
> make check successful.
>
>
> Thanks,
>
> Mandeep Chadha
>
>
Re: Review Request 39056: Fix for Mesos master crash due to check
failure.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39056/#review101684
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos ReviewBot
On Oct. 6, 2015, 5:59 p.m., Mandeep Chadha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39056/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 5:59 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3552
> https://issues.apache.org/jira/browse/MESOS-3552
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Check failed due to double comparison : MESOS-3552.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1
> src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e
>
> Diff: https://reviews.apache.org/r/39056/diff/
>
>
> Testing
> -------
>
> Added unit test.
> make check successful.
>
>
> Thanks,
>
> Mandeep Chadha
>
>