[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1855: Document allowContextMapAll native mode limitations

[GitBox <gi...@apache.org>]

ppalaga commented on a change in pull request #1855:
URL: https://github.com/apache/camel-quarkus/pull/1855#discussion_r497387677



##########
File path: tooling/maven-plugin/src/main/java/org/apache/camel/quarkus/maven/UpdateExtensionDocPageMojo.java
##########
@@ -316,6 +320,29 @@ static boolean detectNativeSsl(Path deploymentBasePath) {
         }
     }
 
+    static boolean detectAllowContextMapAll(CqCatalog catalog, String artifactId) {
+        final String allowContextMapAll = "allowContextMapAll";
+        Optional<ArtifactModel<?>> optional = catalog.filterModels(artifactId).findFirst();

Review comment:
       This may not work as expected if the first model is a LanguageModel or a Dataformat model. I think it would be safer to 
   ```suggestion
           return catalog.filterModels(artifactId)
                   .filter(m -> m instanceof ComponentModel)
                   .map(m -> (ComponentModel) m)
                   .anyMatch(/* your options condition here */)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org