You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/06 10:32:40 UTC

[GitHub] [spark] wangyum commented on a change in pull request #25357: [SPARK-28617][SQL][TEST] Fix misplacement when comment is at the end of the query

wangyum commented on a change in pull request #25357: [SPARK-28617][SQL][TEST] Fix misplacement when comment is at the end of the query
URL: https://github.com/apache/spark/pull/25357#discussion_r310993523
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
 ##########
 @@ -229,6 +229,7 @@ class SQLQueryTestSuite extends QueryTest with SharedSQLContext {
     // List of SQL queries to run
     // note: this is not a robust way to split queries using semicolon, but works for now.
     val queries = code.mkString("\n").split("(?<=[^\\\\]);").map(_.trim).filter(_ != "").toSeq
+      .map(_.split("\n").filterNot(_.startsWith("--")).mkString("\n")).map(_.trim).filter(_ != "")
 
 Review comment:
   OK

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org