You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by ja...@apache.org on 2018/03/05 17:09:40 UTC
[couchdb] branch fix/compaction-daemon updated (eab4095 -> b884abc)
This is an automated email from the ASF dual-hosted git repository.
jan pushed a change to branch fix/compaction-daemon
in repository https://gitbox.apache.org/repos/asf/couchdb.git.
omit eab4095 feat: demote view index opening/closing to log level debug
omit dc7eef9 doc: add snooze_period doc to default.ini
omit 445faf0 bump the compaction daemon check_interval to one hour
omit 354c622 fix: simplify config integer get
new bc32d44 fix: simplify config integer get
new d04128d feat: bump the compaction daemon check_interval to one hour
new 0a6add8 doc: add snooze_period doc to default.ini
new b884abc feat: demote view index opening/closing to log level debug
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (eab4095)
\
N -- N -- N refs/heads/fix/compaction-daemon (b884abc)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
--
To stop receiving notification emails like this one, please contact
jan@apache.org.
[couchdb] 04/04: feat: demote view index opening/closing to log
level debug
Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jan pushed a commit to branch fix/compaction-daemon
in repository https://gitbox.apache.org/repos/asf/couchdb.git
commit b884abc6f9762e4ffc65d85a0c655cb1ac0d917a
Author: Jan Lehnardt <ja...@apache.org>
AuthorDate: Mon Mar 5 16:15:51 2018 +0100
feat: demote view index opening/closing to log level debug
---
src/couch_index/src/couch_index.erl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/couch_index/src/couch_index.erl b/src/couch_index/src/couch_index.erl
index b3a800f..8fba0a2 100644
--- a/src/couch_index/src/couch_index.erl
+++ b/src/couch_index/src/couch_index.erl
@@ -104,7 +104,7 @@ init({Mod, IdxState}) ->
Mod:get(idx_name, IdxState),
couch_index_util:hexsig(Mod:get(signature, IdxState))
],
- couch_log:info("Opening index for db: ~s idx: ~s sig: ~p", Args),
+ couch_log:debug("Opening index for db: ~s idx: ~s sig: ~p", Args),
proc_lib:init_ack({ok, self()}),
gen_server:enter_loop(?MODULE, [], State);
Other ->
@@ -131,7 +131,7 @@ terminate(Reason0, State) ->
couch_index_util:hexsig(Mod:get(signature, IdxState)),
Reason
],
- couch_log:info("Closing index for db: ~s idx: ~s sig: ~p because ~r", Args),
+ couch_log:debug("Closing index for db: ~s idx: ~s sig: ~p because ~r", Args),
ok.
@@ -366,7 +366,7 @@ handle_info(maybe_close, State) ->
end;
handle_info({'DOWN', _, _, _Pid, _}, #st{mod=Mod, idx_state=IdxState}=State) ->
Args = [Mod:get(db_name, IdxState), Mod:get(idx_name, IdxState)],
- couch_log:info("Index shutdown by monitor notice for db: ~s idx: ~s", Args),
+ couch_log:debug("Index shutdown by monitor notice for db: ~s idx: ~s", Args),
catch send_all(State#st.waiters, shutdown),
{stop, normal, State#st{waiters=[]}}.
--
To stop receiving notification emails like this one, please contact
jan@apache.org.
[couchdb] 03/04: doc: add snooze_period doc to default.ini
Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jan pushed a commit to branch fix/compaction-daemon
in repository https://gitbox.apache.org/repos/asf/couchdb.git
commit 0a6add8e9dca1933251b8cbb6f67f32de4628990
Author: Jan Lehnardt <ja...@apache.org>
AuthorDate: Mon Mar 5 16:12:14 2018 +0100
doc: add snooze_period doc to default.ini
---
rel/overlay/etc/default.ini | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/rel/overlay/etc/default.ini b/rel/overlay/etc/default.ini
index 892fc9a..ec3e223 100644
--- a/rel/overlay/etc/default.ini
+++ b/rel/overlay/etc/default.ini
@@ -438,6 +438,12 @@ check_interval = 3600
; compaction will not happen. Very small files always have a very high
; fragmentation therefore it's not worth to compact them.
min_file_size = 131072
+; With lots of databases and/or with lots of design docs in one or more
+; databases, the compaction_daemon can create significant CPU load when
+; checking whether databases and view indexes need compacting. The
+; snooze_period setting ensures a smoother CPU load. Defaults to
+; 3 seconds wait.
+; snooze_period = 3
[compactions]
; List of compaction rules for the compaction daemon.
--
To stop receiving notification emails like this one, please contact
jan@apache.org.
[couchdb] 01/04: fix: simplify config integer get
Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jan pushed a commit to branch fix/compaction-daemon
in repository https://gitbox.apache.org/repos/asf/couchdb.git
commit bc32d443871d308e59a77b06277eefa741dca5cc
Author: Jan Lehnardt <ja...@apache.org>
AuthorDate: Mon Mar 5 16:09:00 2018 +0100
fix: simplify config integer get
---
src/couch/src/couch_compaction_daemon.erl | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/couch/src/couch_compaction_daemon.erl b/src/couch/src/couch_compaction_daemon.erl
index 59555f1..200c3fd 100644
--- a/src/couch/src/couch_compaction_daemon.erl
+++ b/src/couch/src/couch_compaction_daemon.erl
@@ -152,8 +152,7 @@ compact_loop(Parent) ->
true ->
receive {Parent, have_config} -> ok end;
false ->
- PausePeriod = list_to_integer(
- config:get("compaction_daemon", "check_interval", "300")),
+ PausePeriod = config:get_integer("compaction_daemon", "check_interval", 3600),
ok = timer:sleep(PausePeriod * 1000)
end,
compact_loop(Parent).
--
To stop receiving notification emails like this one, please contact
jan@apache.org.
[couchdb] 02/04: feat: bump the compaction daemon check_interval to
one hour
Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jan pushed a commit to branch fix/compaction-daemon
in repository https://gitbox.apache.org/repos/asf/couchdb.git
commit d04128dc3dcb0cea16b268386a8af899c8ddbf51
Author: Jan Lehnardt <ja...@apache.org>
AuthorDate: Mon Mar 5 18:08:16 2018 +0100
feat: bump the compaction daemon check_interval to one hour
---
rel/overlay/etc/default.ini | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rel/overlay/etc/default.ini b/rel/overlay/etc/default.ini
index 4017a0c..892fc9a 100644
--- a/rel/overlay/etc/default.ini
+++ b/rel/overlay/etc/default.ini
@@ -433,7 +433,7 @@ ssl_certificate_max_depth = 3
[compaction_daemon]
; The delay, in seconds, between each check for which database and view indexes
; need to be compacted.
-check_interval = 300
+check_interval = 3600
; If a database or view index file is smaller then this value (in bytes),
; compaction will not happen. Very small files always have a very high
; fragmentation therefore it's not worth to compact them.
--
To stop receiving notification emails like this one, please contact
jan@apache.org.