[trafficserver] branch master updated: Coverity 1390953

[sh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

shinrich pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 183c4ce  Coverity 1390953
183c4ce is described below

commit 183c4ce19b61878f188324626aa0b3076f7f2bdc
Author: Susan Hinrichs <sh...@apache.org>
AuthorDate: Thu May 10 09:12:06 2018 +0000

    Coverity 1390953
---
 proxy/http/HttpTransact.cc | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/proxy/http/HttpTransact.cc b/proxy/http/HttpTransact.cc
index 12ddf0b..406e9e8 100644
--- a/proxy/http/HttpTransact.cc
+++ b/proxy/http/HttpTransact.cc
@@ -5392,11 +5392,7 @@ HttpTransact::handle_trace_and_options_requests(State *s, HTTPHdr *incoming_hdr)
 
     // Logically want to make sure max_forwards is a legitimate non-zero non-negative integer
     // Since max_fowards is a signed integer, no sense making sure it is less than INT_MAX.
-    // Would be negative in that case. Noted by coverity
-    if (max_forwards <= 0) {
-      Log::error("HTTP: snapping invalid max-forwards value %d to %d", max_forwards, INT_MAX);
-      max_forwards = INT_MAX;
-    }
+    // Would be negative in that case.  Already checked negative in the other case.  Noted by coverity
 
     --max_forwards;
     TxnDebug("http_trans", "[handle_trace_options] Decrementing max_forwards to %d", max_forwards);

-- 
To stop receiving notification emails like this one, please contact
shinrich@apache.org.