[GitHub] [spark] cloud-fan commented on a change in pull request #26150: [SPARK-29501][SQL] SupportsPushDownRequiredColumns should report pruned schema immediately

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #26150: [SPARK-29501][SQL] SupportsPushDownRequiredColumns should report pruned schema immediately
URL: https://github.com/apache/spark/pull/26150#discussion_r336860339
 
 

 ##########
 File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/Scan.java
 ##########
 @@ -38,16 +36,10 @@
 @Evolving
 public interface Scan {
 
-  /**
-   * Returns the actual schema of this data source scan, which may be different from the physical
-   * schema of the underlying storage, as column pruning or other optimizations may happen.
-   */
-  StructType readSchema();
-
   /**
    * A description string of this scan, which may includes information like: what filters are
    * configured for this scan, what's the value of some important options like path, etc. The
-   * description doesn't need to include {@link #readSchema()}, as Spark already knows it.
+   * description doesn't need to include the schema, as Spark already knows it.
 
 Review comment:
   > ... like pushed filters and residual filters.
   
   hmm, are these already available from `SupportsPushDownFilters`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org