You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pdion891 <gi...@git.apache.org> on 2015/09/28 02:57:09 UTC
[GitHub] cloudstack pull request: Fix dockerbuild because hardcoded filenam...
GitHub user pdion891 opened a pull request:
https://github.com/apache/cloudstack/pull/893
Fix dockerbuild because hardcoded filename for marvin
This fix docker simulator build of latest 4.5.x.
This PR only go in 4.5 branch.
Thanks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pdion891/cloudstack 4.5-dockerfile
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/893.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #893
----
commit 04ffeb8f350d7858be52bf9fbc5506b01fdf31a2
Author: Pierre-Luc Dion <pd...@apache.org>
Date: 2015-09-28T00:53:34Z
Fix dockerbuild because hardcoded filename for marvin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix dockerbuild because hardcoded filenam...
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 closed the pull request at:
https://github.com/apache/cloudstack/pull/893
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: Fix dockerbuild because
hardcoded filenam...
Posted by Pierre-Luc Dion <pd...@apache.org>.
Hi,
Can someone LGTM this PR ? or we don't need the 2 LGTM as it's not on
master?
This fix the build of cloudstack simulator docker container of 4.5.x
Thanks
On Sun, Sep 27, 2015 at 8:57 PM, pdion891 <gi...@git.apache.org> wrote:
> GitHub user pdion891 opened a pull request:
>
> https://github.com/apache/cloudstack/pull/893
>
> Fix dockerbuild because hardcoded filename for marvin
>
> This fix docker simulator build of latest 4.5.x.
>
> This PR only go in 4.5 branch.
>
> Thanks
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/pdion891/cloudstack 4.5-dockerfile
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/cloudstack/pull/893.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #893
>
> ----
> commit 04ffeb8f350d7858be52bf9fbc5506b01fdf31a2
> Author: Pierre-Luc Dion <pd...@apache.org>
> Date: 2015-09-28T00:53:34Z
>
> Fix dockerbuild because hardcoded filename for marvin
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cloudstack pull request: Fix dockerbuild because hardcoded filenam...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/893#issuecomment-144046791
LGTM Based on code review. Not tested against a real environment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix dockerbuild because hardcoded filenam...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/893#issuecomment-144048504
LGTM based on code review (1 line removed, 2 lines added).
This does not change cloudstack code, the Dockerfile is only used by the docker hub to build the container.
I will test the container once this is merged and the build succeeds.
@pdion891 you can go ahead on merge this in the 4.5 branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix dockerbuild because hardcoded filenam...
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/893#issuecomment-144051603
Thanks Guys!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---