You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/08 01:39:45 UTC

[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1760: jest unit test demo

break60 opened a new pull request #1760: jest unit test demo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1760
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] nauu commented on issue #1760: jest unit test demo

Posted by GitBox <gi...@apache.org>.
nauu commented on issue #1760: jest unit test demo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1760#issuecomment-571859116
 
 
   I think these commits should rebase.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1760: jest unit test demo

Posted by GitBox <gi...@apache.org>.
qiaozhanwei merged pull request #1760: jest unit test demo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1760
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1760: jest unit test demo

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1760: jest unit test demo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1760#issuecomment-571865280
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760?src=pr&el=h1) Report
   > Merging [#1760](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/b4432524972460374150848c74d9baf10a2be392?src=pr&el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `5.93%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              dev    #1760      +/-   ##
   ==========================================
   - Coverage   20.27%   20.21%   -0.07%     
   ==========================================
     Files         287      290       +3     
     Lines       14039    14082      +43     
     Branches     2369     2376       +7     
   ==========================================
     Hits         2847     2847              
   - Misses      10867    10910      +43     
     Partials      325      325
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...e/dolphinscheduler/api/service/UdfFuncService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVWRmRnVuY1NlcnZpY2UuamF2YQ==) | `86.36% <ø> (ø)` | :arrow_up: |
   | [...che/dolphinscheduler/api/utils/ZooKeeperState.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL1pvb0tlZXBlclN0YXRlLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...e/dolphinscheduler/server/master/MasterServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9NYXN0ZXJTZXJ2ZXIuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [...he/dolphinscheduler/server/utils/ProcessUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1Byb2Nlc3NVdGlscy5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [...server/master/runner/MasterBaseTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyQmFzZVRhc2tFeGVjVGhyZWFkLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...olphinscheduler/server/quartz/QuartzExecutors.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3F1YXJ0ei9RdWFydHpFeGVjdXRvcnMuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [...ler/server/master/runner/MasterTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyVGFza0V4ZWNUaHJlYWQuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [...heduler/server/master/runner/MasterExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyRXhlY1RocmVhZC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [.../apache/dolphinscheduler/server/rpc/LogClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3JwYy9Mb2dDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [...he/dolphinscheduler/api/service/TenantService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGVuYW50U2VydmljZS5qYXZh) | `68.42% <0%> (-4.48%)` | :arrow_down: |
   | ... and [16 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760?src=pr&el=footer). Last update [b443252...4665353](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1760?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] break60 commented on issue #1760: jest unit test demo

Posted by GitBox <gi...@apache.org>.
break60 commented on issue #1760: jest unit test demo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1760#issuecomment-571860799
 
 
   > I think these commits should rebase.
   
   Currently jest is just a simple unit test demo. Some issues require community support and improvement without affecting other code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1760: jest unit test demo

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1760: jest unit test demo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1760#issuecomment-571866003
 
 
   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1760&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1760&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1760&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1760&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1760&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1760&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1760&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1760&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1760&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1760&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1760&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1760&metric=coverage&view=list) No Coverage information  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1760&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1760&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services