You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/12/02 06:19:05 UTC
[kudu-CR] WIP: KUDU-1622. Stripe the ResultTracker to lessen contention
Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5322
to review the following change.
Change subject: WIP: KUDU-1622. Stripe the ResultTracker to lessen contention
......................................................................
WIP: KUDU-1622. Stripe the ResultTracker to lessen contention
In various stress tests I've seen the ResultTracker be a significant
bottleneck, with many threads blocked on this lock. This stripes the
data structure to try to reduce that contention.
Change-Id: I3c5a6c2177b85e8dcdbc41ba655de224e8a656f7
---
M src/kudu/rpc/result_tracker.cc
M src/kudu/rpc/result_tracker.h
2 files changed, 297 insertions(+), 188 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/5322/1
--
To view, visit http://gerrit.cloudera.org:8080/5322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c5a6c2177b85e8dcdbc41ba655de224e8a656f7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] WIP: KUDU-1622. Stripe the ResultTracker to lessen contention
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: WIP: KUDU-1622. Stripe the ResultTracker to lessen contention
......................................................................
Patch Set 1:
with your recent changes is striping still needed?
--
To view, visit http://gerrit.cloudera.org:8080/5322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c5a6c2177b85e8dcdbc41ba655de224e8a656f7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] WIP: KUDU-1622. Stripe the ResultTracker to lessen contention
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has abandoned this change.
Change subject: WIP: KUDU-1622. Stripe the ResultTracker to lessen contention
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/5322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I3c5a6c2177b85e8dcdbc41ba655de224e8a656f7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] WIP: KUDU-1622. Stripe the ResultTracker to lessen contention
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: WIP: KUDU-1622. Stripe the ResultTracker to lessen contention
......................................................................
Patch Set 1:
haven't looked in detail at a contention profile after those changes. I'll abandon this for now.
--
To view, visit http://gerrit.cloudera.org:8080/5322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c5a6c2177b85e8dcdbc41ba655de224e8a656f7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No