You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by am...@apache.org on 2016/02/02 04:48:11 UTC
svn commit: r1728037 -
/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/blob/MarkSweepGarbageCollector.java
Author: amitj
Date: Tue Feb 2 03:48:10 2016
New Revision: 1728037
URL: http://svn.apache.org/viewvc?rev=1728037&view=rev
Log:
OAK-3527: Improve logging for blob GC
Added logging for markOnly param
Logging maxModified time
Modified:
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/blob/MarkSweepGarbageCollector.java
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/blob/MarkSweepGarbageCollector.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/blob/MarkSweepGarbageCollector.java?rev=1728037&r1=1728036&r2=1728037&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/blob/MarkSweepGarbageCollector.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/blob/MarkSweepGarbageCollector.java Tue Feb 2 03:48:10 2016
@@ -242,7 +242,7 @@ public class MarkSweepGarbageCollector i
GarbageCollectorFileState fs = new GarbageCollectorFileState(root);
try {
Stopwatch sw = Stopwatch.createStarted();
- LOG.info("Starting Blob garbage collection");
+ LOG.info("Starting Blob garbage collection with markOnly [{}]", markOnly);
long markStart = System.currentTimeMillis();
mark(fs);
@@ -250,8 +250,9 @@ public class MarkSweepGarbageCollector i
long deleteCount = sweep(fs, markStart);
threw = false;
- LOG.info("Blob garbage collection completed in {}. Number of blobs deleted [{}]", sw.toString(),
- deleteCount, maxLastModifiedInterval);
+ long maxTime = maxLastModifiedInterval > 0 ? maxLastModifiedInterval : markStart;
+ LOG.info("Blob garbage collection completed in {}. Number of blobs deleted [{}] with max modification time of [{}]",
+ sw.toString(), deleteCount, timestampToString(maxTime));
}
} catch (Exception e) {
LOG.error("Blob garbage collection error", e);