You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "hello-stephen (via GitHub)" <gi...@apache.org> on 2026/10/08 19:26:43 UTC
[PR] branch-4.1: [fix](expr) Canonicalize logical OR results [doris]
hello-stephen opened a new pull request, #68798:
URL: https://github.com/apache/doris/pull/68798
### What problem does this PR solve?
Backport #68308 / #68401 to branch-4.1. The repair is present on branch-4.1.4, but branch-4.1 at c8c0ddca4d4d452bcb236f2499c5fed9a3c68780 still has the same three unnormalized OR paths as 4.1.5-rc01 (7fda449b7afb09c266ce2c4fc738a4d5e46fc458).
A nullable Boolean can contain an arbitrary hidden byte. When the other operand makes OR non-null, preserving the bitwise result can expose a value other than 0 or 1. Release regression reproduced incorrect Boolean grouping on the original candidate in both LOCAL and S3 modes.
This is an exact backport of fc344110d103312a6bfafb55e936b76f26177b8e, preserving its author and all five changed files: normalize FunctionOr and both compound OR paths, add three BE unit tests, and include the original regression suite and unchanged golden output. No unrelated NULL/CASE implementation changes are included.
### Release note
Fix noncanonical logical OR results involving hidden NULL payloads.
### Check List (For Author)
- Validation: patch applies cleanly to the stated branch-4.1 base; all five resulting files are byte-identical to the original fixed commit; git diff --check passes.
- Runtime validation: this new backport has not run BE unit tests or live regression yet. Required validation is FunctionsLogicalTest.* and test_json_extract_bool_null_payload in LOCAL/S3, with both short-circuit settings, against a binary built from this PR's exact SHA.
- The existing candidate failure remains a release blocker. This PR does not replace the candidate artifact or establish a passing release result.
- Duplicate check: currently open branch-4.1 PR file lists and matching repair references were checked; no equivalent open backport was found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1: [fix](expr) Canonicalize logical OR results [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68798:
URL: https://github.com/apache/doris/pull/68798#issuecomment-6081252134
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (3/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/68798_eee63e9b2f66e0787fe1349f380994a3ff7c181f_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/68798_eee63e9b2f66e0787fe1349f380994a3ff7c181f_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 75.05% (32010/42652) |
| Line Coverage | 59.45% (359018/603909) |
| Region Coverage | 56.06% (298868/533133) |
| Branch Coverage | 56.96% (135593/238037) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1: [fix](expr) Canonicalize logical OR results [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68798:
URL: https://github.com/apache/doris/pull/68798#issuecomment-6067435257
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1: [fix](expr) Canonicalize logical OR results [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #68798:
URL: https://github.com/apache/doris/pull/68798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1: [fix](expr) Canonicalize logical OR results [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #68798:
URL: https://github.com/apache/doris/pull/68798#issuecomment-6075947296
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1: [fix](expr) Canonicalize logical OR results [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #68798:
URL: https://github.com/apache/doris/pull/68798#issuecomment-6092120530
skip buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org