You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (Jira)" <ji...@apache.org> on 2020/04/10 11:54:00 UTC
[jira] [Commented] (HIVE-22165) Synchronisation introduced by
HIVE-14296 on SessionManager.closeSession causes high latency in a busy
hive server
[ https://issues.apache.org/jira/browse/HIVE-22165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17080441#comment-17080441 ]
Hive QA commented on HIVE-22165:
--------------------------------
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m 40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 54s{color} | {color:blue} service in master has 49 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 25s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 20m 32s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21547/dev-support/hive-personality.sh |
| git revision | master / 5f47808 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: service U: service |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21547/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Synchronisation introduced by HIVE-14296 on SessionManager.closeSession causes high latency in a busy hive server
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-22165
> URL: https://issues.apache.org/jira/browse/HIVE-22165
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
> Affects Versions: 2.1.0, 2.3.2
> Reporter: Amruth Sampath
> Assignee: Amruth Sampath
> Priority: Major
> Attachments: HIVE-22165.02.patch, HIVE-22165.patch, HIVE-22165.patch.1
>
>
> HIVE-14296 introduces this [commit|https://github.com/apache/hive/commit/477a47d3b4b9e3da3c22465217c2024588f7f000] which adds synchronization to SessionManager.closeSession.
> And it looks like it is used only for logging purposes.
> In a busy hive server where 5-10 sessions are created closed every second, an increase in latency of any other downstream services (Zk, HDFS) causes a queueing effect (lot of threads getting blocked on SessionManager.closeSession) creating an induced latency of 3-5 minutes at times for just closing the session.
> Since the gauge (MetricsConstant.HS2_OPEN_SESSIONS) is already tracking the open session counts, the synchronization (along with the additional logging) can be removed without any functionality losses.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)