You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/10/19 08:40:51 UTC
[GitHub] [ozone] guohao-rosicky opened a new pull request #2749: HDDS-5868. Change getBucketInfo annotation
guohao-rosicky opened a new pull request #2749:
URL: https://github.com/apache/ozone/pull/2749
Change getBucketInfo annotation
jira: https://issues.apache.org/jira/browse/HDDS-5868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guohao-rosicky commented on a change in pull request #2749: HDDS-5868. Change getBucketInfo annotation
Posted by GitBox <gi...@apache.org>.
guohao-rosicky commented on a change in pull request #2749:
URL: https://github.com/apache/ozone/pull/2749#discussion_r733303584
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java
##########
@@ -570,7 +570,7 @@ protected static long sumBlockLengths(OmKeyInfo omKeyInfo) {
* @param omMetadataManager
* @param volume
* @param bucket
- * @return OmVolumeArgs
+ * @return OmBucketInfo
* @throws IOException
Review comment:
Has been modified, Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] captainzmc merged pull request #2749: HDDS-5868. Change getBucketInfo annotation
Posted by GitBox <gi...@apache.org>.
captainzmc merged pull request #2749:
URL: https://github.com/apache/ozone/pull/2749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #2749: HDDS-5868. Change getBucketInfo annotation
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #2749:
URL: https://github.com/apache/ozone/pull/2749#discussion_r731715940
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java
##########
@@ -570,7 +570,7 @@ protected static long sumBlockLengths(OmKeyInfo omKeyInfo) {
* @param omMetadataManager
* @param volume
* @param bucket
- * @return OmVolumeArgs
+ * @return OmBucketInfo
* @throws IOException
Review comment:
Also, description is mandatory for Javadoc `@param x`. I would prefer removing these tags completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guohao-rosicky commented on a change in pull request #2749: HDDS-5868. Change getBucketInfo annotation
Posted by GitBox <gi...@apache.org>.
guohao-rosicky commented on a change in pull request #2749:
URL: https://github.com/apache/ozone/pull/2749#discussion_r735228162
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java
##########
@@ -570,7 +570,7 @@ protected static long sumBlockLengths(OmKeyInfo omKeyInfo) {
* @param omMetadataManager
* @param volume
* @param bucket
- * @return OmVolumeArgs
+ * @return OmBucketInfo
* @throws IOException
Review comment:
thanks @adoroszlai @ayushtkn, has been modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on a change in pull request #2749: HDDS-5868. Change getBucketInfo annotation
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on a change in pull request #2749:
URL: https://github.com/apache/ozone/pull/2749#discussion_r734167842
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java
##########
@@ -570,7 +570,7 @@ protected static long sumBlockLengths(OmKeyInfo omKeyInfo) {
* @param omMetadataManager
* @param volume
* @param bucket
- * @return OmVolumeArgs
+ * @return OmBucketInfo
* @throws IOException
Review comment:
@guohao-rosicky I think @adoroszlai suggested to remove the complete javadoc itself, since it doesn’t have any description.
@adoroszlai did I catch you correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #2749: HDDS-5868. Change getBucketInfo annotation
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #2749:
URL: https://github.com/apache/ozone/pull/2749#discussion_r734296102
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java
##########
@@ -570,7 +570,7 @@ protected static long sumBlockLengths(OmKeyInfo omKeyInfo) {
* @param omMetadataManager
* @param volume
* @param bucket
- * @return OmVolumeArgs
+ * @return OmBucketInfo
* @throws IOException
Review comment:
> suggested to remove the complete javadoc itself, since it doesn’t have any description.
Correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on a change in pull request #2749: HDDS-5868. Change getBucketInfo annotation
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on a change in pull request #2749:
URL: https://github.com/apache/ozone/pull/2749#discussion_r731710494
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java
##########
@@ -570,7 +570,7 @@ protected static long sumBlockLengths(OmKeyInfo omKeyInfo) {
* @param omMetadataManager
* @param volume
* @param bucket
- * @return OmVolumeArgs
+ * @return OmBucketInfo
* @throws IOException
Review comment:
I think the method doesn't throw IOE either, Can you check, If not can remove it as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org