You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Flavio Percoco <fl...@gmail.com> on 2015/06/11 22:39:00 UTC
Review Request 35369: PROTON-895: Let tox handle sdist and install
steps
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35369/
-----------------------------------------------------------
Review request for qpid, Gordon Sim, Kenneth Giusti, and Rafael Schloming.
Repository: qpid-proton-git
Description
-------
Since we're not using cmake anymore, we can let tox handle the sdist and
install steps so that everything happens within the tox venv.
Diffs
-----
proton-c/bindings/python/tox.ini aab5e4e
Diff: https://reviews.apache.org/r/35369/diff/
Testing
-------
Thanks,
Flavio Percoco
Re: Review Request 35369: PROTON-895: Let tox handle sdist and
install steps
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35369/#review87719
-----------------------------------------------------------
Ship it!
This change makes the python-tox-test work exactly as I would expect it to: pip install the locally generated python-qpid-proton sdist in a virtualenv using the local proton-c sources (not sources downloaded from apache).
This is perfect.
- Kenneth Giusti
On June 11, 2015, 8:39 p.m., Flavio Percoco wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35369/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 8:39 p.m.)
>
>
> Review request for qpid, Gordon Sim, Kenneth Giusti, and Rafael Schloming.
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> Since we're not using cmake anymore, we can let tox handle the sdist and
> install steps so that everything happens within the tox venv.
>
>
> Diffs
> -----
>
> proton-c/bindings/python/tox.ini aab5e4e
>
> Diff: https://reviews.apache.org/r/35369/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Flavio Percoco
>
>