You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Robbie Zhang (Code Review)" <ge...@cloudera.org> on 2019/02/15 08:07:23 UTC
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Robbie Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12498
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
IMPALA-8108: Impala query returns TIMESTAMP values in different types
Impala uses function boost::posix_time::to_simple_string(time_duration)
to convert timestamp to a string and to_simple_string() remove fractional
seconds if they are all zeros.
In order to output timestamp values in the same format, we add padding
zeros if where isn't fractional seconds.
Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
---
M be/src/runtime/timestamp-value.cc
A testdata/workloads/functional-query/queries/QueryTest/timestamps.test
A tests/query_test/test_timestamps.py
3 files changed, 66 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/12498/1
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 1
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Robbie Zhang (Code Review)" <ge...@cloudera.org>.
Hello Greg Rahn, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12498
to look at the new patch set (#2).
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
IMPALA-8108: Impala query returns TIMESTAMP values in different types
Impala uses function boost::posix_time::to_simple_string(time_duration)
to convert timestamp to a string and to_simple_string() remove fractional
seconds if they are all zeros.
In order to output timestamp values in the same format, we add padding
zeros if where isn't fractional seconds.
Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
---
M be/src/runtime/timestamp-value.cc
A testdata/workloads/functional-query/queries/QueryTest/timestamps.test
A tests/query_test/test_timestamps.py
3 files changed, 64 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/12498/2
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 2
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3858/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 4
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Mar 2019 22:10:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/12498/1/tests/query_test/test_timestamps.py
File tests/query_test/test_timestamps.py:
http://gerrit.cloudera.org:8080/#/c/12498/1/tests/query_test/test_timestamps.py@18
PS1, Line 18: import pytest
flake8: F401 'pytest' imported but unused
http://gerrit.cloudera.org:8080/#/c/12498/1/tests/query_test/test_timestamps.py@21
PS1, Line 21: from tests.util.filesystem_utils import get_fs_path
flake8: F401 'tests.util.filesystem_utils.get_fs_path' imported but unused
http://gerrit.cloudera.org:8080/#/c/12498/1/tests/query_test/test_timestamps.py@23
PS1, Line 23: class TestTimestampFormats(ImpalaTestSuite):
flake8: E302 expected 2 blank lines, found 1
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 1
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 08:08:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12498/2/tests/query_test/test_timestamps.py
File tests/query_test/test_timestamps.py:
http://gerrit.cloudera.org:8080/#/c/12498/2/tests/query_test/test_timestamps.py@20
PS2, Line 20: class TestTimestampFormats(ImpalaTestSuite):
flake8: E302 expected 2 blank lines, found 1
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 2
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 08:21:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2139/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 2
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 08:53:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3859/
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 5
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 02:47:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3858/
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 4
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 03 Mar 2019 02:31:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 4:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/12498/4/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:
http://gerrit.cloudera.org:8080/#/c/12498/4/be/src/exprs/expr-test.cc@5631
PS4, Line 5631: "cast('2013-09-26 12:00:00' as timestamp)) as string)", "2013-09-26 12:00:00.000000000");
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/12498/4/be/src/exprs/expr-test.cc@5688
PS4, Line 5688: "cast('2013-09-26 12:00:00' as timestamp)) as string)", "2014-09-26 12:00:00.000000000");
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/12498/4/be/src/exprs/expr-test.cc@7044
PS4, Line 7044: TestStringValue("cast(cast('09:10:11+01:30' as timestamp) as string)", "09:10:11.000000000");
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/12498/4/be/src/exprs/expr-test.cc@7045
PS4, Line 7045: TestStringValue("cast(cast('09:10:11-01:30' as timestamp) as string)", "09:10:11.000000000");
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/12498/4/tests/data_errors/test_data_errors.py
File tests/data_errors/test_data_errors.py:
http://gerrit.cloudera.org:8080/#/c/12498/4/tests/data_errors/test_data_errors.py@226
PS4, Line 226: '
flake8: E501 line too long (94 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/12498/4/tests/data_errors/test_data_errors.py@226
PS4, Line 226: \
flake8: E502 the backslash is redundant between brackets
http://gerrit.cloudera.org:8080/#/c/12498/4/tests/hs2/test_fetch.py
File tests/hs2/test_fetch.py:
http://gerrit.cloudera.org:8080/#/c/12498/4/tests/hs2/test_fetch.py@137
PS4, Line 137: 1
flake8: E501 line too long (100 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/12498/4/tests/query_test/test_aggregation.py
File tests/query_test/test_aggregation.py:
http://gerrit.cloudera.org:8080/#/c/12498/4/tests/query_test/test_aggregation.py@78
PS4, Line 78: 0
flake8: E501 line too long (95 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 4
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Mar 2019 11:30:01 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 6
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 14:05:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2328/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 5
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 03 Mar 2019 23:16:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Robbie Zhang (Code Review)" <ge...@cloudera.org>.
Hello Greg Rahn, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12498
to look at the new patch set (#3).
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
IMPALA-8108: Impala query returns TIMESTAMP values in different types
Impala uses function boost::posix_time::to_simple_string(time_duration)
to convert timestamp to a string and to_simple_string() remove fractional
seconds if they are all zeros.
In order to output timestamp values in the same format, we add padding
zeros if where isn't fractional seconds.
Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
---
M be/src/runtime/timestamp-value.cc
A testdata/workloads/functional-query/queries/QueryTest/timestamps.test
A tests/query_test/test_timestamps.py
3 files changed, 65 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/12498/3
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 3
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2140/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 3
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 09:01:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3784/
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 3
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 21:31:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2333/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 6
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 10:28:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Robbie Zhang (Code Review)" <ge...@cloudera.org>.
Hello Greg Rahn, Attila Jeges, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12498
to look at the new patch set (#4).
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
IMPALA-8108: Impala query returns TIMESTAMP values in different types
Impala uses function boost::posix_time::to_simple_string(time_duration)
to convert timestamp to a string and to_simple_string() remove fractional
seconds if they are all zeros.
In order to output timestamp values in the same format, we add padding
zeros if where isn't fractional seconds.
TESTING:
Added end-to-end test test_timestamps to verify the results.
Because all timestamp values have fractional seconds, expected results
in test data and test scripts are updated as well.
Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
---
M be/src/exprs/expr-test.cc
M be/src/runtime/timestamp-test.cc
M be/src/runtime/timestamp-value.cc
M testdata/workloads/functional-query/queries/DataErrorsTest/hdfs-scan-node-errors.test
M testdata/workloads/functional-query/queries/DataErrorsTest/orc-type-checks.test
M testdata/workloads/functional-query/queries/QueryTest/aggregation.test
M testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test
M testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test
M testdata/workloads/functional-query/queries/QueryTest/compute-stats.test
M testdata/workloads/functional-query/queries/QueryTest/create-table-as-select.test
M testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test
M testdata/workloads/functional-query/queries/QueryTest/distinct.test
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
M testdata/workloads/functional-query/queries/QueryTest/hbase-filters.test
M testdata/workloads/functional-query/queries/QueryTest/hbase-scan-node.test
M testdata/workloads/functional-query/queries/QueryTest/hdfs-scan-node.test
M testdata/workloads/functional-query/queries/QueryTest/inline-view-limit.test
M testdata/workloads/functional-query/queries/QueryTest/inline-view.test
M testdata/workloads/functional-query/queries/QueryTest/insert.test
M testdata/workloads/functional-query/queries/QueryTest/joins.test
M testdata/workloads/functional-query/queries/QueryTest/kudu-overflow-ts.test
M testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_limit.test
M testdata/workloads/functional-query/queries/QueryTest/limit.test
M testdata/workloads/functional-query/queries/QueryTest/local-timestamp-functions.test
M testdata/workloads/functional-query/queries/QueryTest/multiple-filesystems.test
M testdata/workloads/functional-query/queries/QueryTest/out-of-range-timestamp-continue-on-error.test
M testdata/workloads/functional-query/queries/QueryTest/out-of-range-timestamp-local-tz-conversion.test
M testdata/workloads/functional-query/queries/QueryTest/parquet-def-levels.test
M testdata/workloads/functional-query/queries/QueryTest/parquet-int64-timestamps.test
M testdata/workloads/functional-query/queries/QueryTest/parquet.test
M testdata/workloads/functional-query/queries/QueryTest/select-lazy-timestamp.test
M testdata/workloads/functional-query/queries/QueryTest/subquery.test
A testdata/workloads/functional-query/queries/QueryTest/timestamps.test
M testdata/workloads/functional-query/queries/QueryTest/top-n.test
M testdata/workloads/functional-query/queries/QueryTest/truncate-table.test
M testdata/workloads/functional-query/queries/QueryTest/udf.test
M testdata/workloads/functional-query/queries/QueryTest/union.test
M testdata/workloads/functional-query/queries/QueryTest/utc-timestamp-functions.test
M testdata/workloads/functional-query/queries/QueryTest/views.test
M tests/custom_cluster/test_hive_parquet_timestamp_conversion.py
M tests/data_errors/test_data_errors.py
M tests/hs2/test_fetch.py
M tests/query_test/test_aggregation.py
A tests/query_test/test_timestamps.py
47 files changed, 1,160 insertions(+), 860 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/12498/4
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 4
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3784/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 3
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 17:30:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12498/5/tests/data_errors/test_data_errors.py
File tests/data_errors/test_data_errors.py:
http://gerrit.cloudera.org:8080/#/c/12498/5/tests/data_errors/test_data_errors.py@226
PS5, Line 226: \
flake8: E502 the backslash is redundant between brackets
http://gerrit.cloudera.org:8080/#/c/12498/5/tests/data_errors/test_data_errors.py@227
PS5, Line 227: \
flake8: E502 the backslash is redundant between brackets
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 5
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 03 Mar 2019 22:34:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Robbie Zhang (Code Review)" <ge...@cloudera.org>.
Hello Greg Rahn, Attila Jeges, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12498
to look at the new patch set (#6).
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
IMPALA-8108: Impala query returns TIMESTAMP values in different types
Impala uses function boost::posix_time::to_simple_string(time_duration)
to convert timestamp to a string and to_simple_string() remove fractional
seconds if they are all zeros.
In order to output timestamp values in the same format, we add padding
zeros if where isn't fractional seconds.
TESTING:
Added end-to-end test test_timestamps to verify the results.
Because all timestamp values have fractional seconds, expected results
in test data and test scripts are updated as well.
Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
---
M be/src/exprs/expr-test.cc
M be/src/runtime/timestamp-test.cc
M be/src/runtime/timestamp-value.cc
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/conjunct-ordering.test
M testdata/workloads/functional-planner/queries/PlannerTest/constant-folding.test
M testdata/workloads/functional-planner/queries/PlannerTest/join-order.test
M testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test
M testdata/workloads/functional-planner/queries/PlannerTest/kudu.test
M testdata/workloads/functional-planner/queries/PlannerTest/outer-joins.test
M testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering-disabled.test
M testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering.test
M testdata/workloads/functional-planner/queries/PlannerTest/partition-pruning.test
M testdata/workloads/functional-query/queries/DataErrorsTest/hdfs-scan-node-errors.test
M testdata/workloads/functional-query/queries/DataErrorsTest/orc-type-checks.test
M testdata/workloads/functional-query/queries/QueryTest/aggregation.test
M testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test
M testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test
M testdata/workloads/functional-query/queries/QueryTest/compute-stats.test
M testdata/workloads/functional-query/queries/QueryTest/create-table-as-select.test
M testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test
M testdata/workloads/functional-query/queries/QueryTest/distinct.test
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
M testdata/workloads/functional-query/queries/QueryTest/hbase-filters.test
M testdata/workloads/functional-query/queries/QueryTest/hbase-scan-node.test
M testdata/workloads/functional-query/queries/QueryTest/hdfs-scan-node.test
M testdata/workloads/functional-query/queries/QueryTest/inline-view-limit.test
M testdata/workloads/functional-query/queries/QueryTest/inline-view.test
M testdata/workloads/functional-query/queries/QueryTest/insert.test
M testdata/workloads/functional-query/queries/QueryTest/joins.test
M testdata/workloads/functional-query/queries/QueryTest/kudu-overflow-ts.test
M testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_limit.test
M testdata/workloads/functional-query/queries/QueryTest/limit.test
M testdata/workloads/functional-query/queries/QueryTest/local-timestamp-functions.test
M testdata/workloads/functional-query/queries/QueryTest/multiple-filesystems.test
M testdata/workloads/functional-query/queries/QueryTest/out-of-range-timestamp-continue-on-error.test
M testdata/workloads/functional-query/queries/QueryTest/out-of-range-timestamp-local-tz-conversion.test
M testdata/workloads/functional-query/queries/QueryTest/parquet-def-levels.test
M testdata/workloads/functional-query/queries/QueryTest/parquet-int64-timestamps.test
M testdata/workloads/functional-query/queries/QueryTest/parquet.test
M testdata/workloads/functional-query/queries/QueryTest/select-lazy-timestamp.test
M testdata/workloads/functional-query/queries/QueryTest/subquery.test
A testdata/workloads/functional-query/queries/QueryTest/timestamps.test
M testdata/workloads/functional-query/queries/QueryTest/top-n.test
M testdata/workloads/functional-query/queries/QueryTest/truncate-table.test
M testdata/workloads/functional-query/queries/QueryTest/udf.test
M testdata/workloads/functional-query/queries/QueryTest/union.test
M testdata/workloads/functional-query/queries/QueryTest/utc-timestamp-functions.test
M testdata/workloads/functional-query/queries/QueryTest/views.test
M tests/custom_cluster/test_hive_parquet_timestamp_conversion.py
M tests/data_errors/test_data_errors.py
M tests/hs2/test_fetch.py
M tests/query_test/test_aggregation.py
A tests/query_test/test_timestamps.py
57 files changed, 1,201 insertions(+), 894 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/12498/6
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 6
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2327/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 4
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Mar 2019 12:10:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Robbie Zhang (Code Review)" <ge...@cloudera.org>.
Hello Greg Rahn, Attila Jeges, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12498
to look at the new patch set (#5).
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
IMPALA-8108: Impala query returns TIMESTAMP values in different types
Impala uses function boost::posix_time::to_simple_string(time_duration)
to convert timestamp to a string and to_simple_string() remove fractional
seconds if they are all zeros.
In order to output timestamp values in the same format, we add padding
zeros if where isn't fractional seconds.
TESTING:
Added end-to-end test test_timestamps to verify the results.
Because all timestamp values have fractional seconds, expected results
in test data and test scripts are updated as well.
Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
---
M be/src/exprs/expr-test.cc
M be/src/runtime/timestamp-test.cc
M be/src/runtime/timestamp-value.cc
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/conjunct-ordering.test
M testdata/workloads/functional-planner/queries/PlannerTest/constant-folding.test
M testdata/workloads/functional-planner/queries/PlannerTest/join-order.test
M testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test
M testdata/workloads/functional-planner/queries/PlannerTest/kudu.test
M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test
M testdata/workloads/functional-planner/queries/PlannerTest/outer-joins.test
M testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering-disabled.test
M testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering.test
M testdata/workloads/functional-planner/queries/PlannerTest/partition-pruning.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpch-nested.test
M testdata/workloads/functional-query/queries/DataErrorsTest/hdfs-scan-node-errors.test
M testdata/workloads/functional-query/queries/DataErrorsTest/orc-type-checks.test
M testdata/workloads/functional-query/queries/QueryTest/aggregation.test
M testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test
M testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test
M testdata/workloads/functional-query/queries/QueryTest/compute-stats.test
M testdata/workloads/functional-query/queries/QueryTest/create-table-as-select.test
M testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test
M testdata/workloads/functional-query/queries/QueryTest/distinct.test
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
M testdata/workloads/functional-query/queries/QueryTest/hbase-filters.test
M testdata/workloads/functional-query/queries/QueryTest/hbase-scan-node.test
M testdata/workloads/functional-query/queries/QueryTest/hdfs-scan-node.test
M testdata/workloads/functional-query/queries/QueryTest/inline-view-limit.test
M testdata/workloads/functional-query/queries/QueryTest/inline-view.test
M testdata/workloads/functional-query/queries/QueryTest/insert.test
M testdata/workloads/functional-query/queries/QueryTest/joins.test
M testdata/workloads/functional-query/queries/QueryTest/kudu-overflow-ts.test
M testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_limit.test
M testdata/workloads/functional-query/queries/QueryTest/limit.test
M testdata/workloads/functional-query/queries/QueryTest/local-timestamp-functions.test
M testdata/workloads/functional-query/queries/QueryTest/multiple-filesystems.test
M testdata/workloads/functional-query/queries/QueryTest/out-of-range-timestamp-continue-on-error.test
M testdata/workloads/functional-query/queries/QueryTest/out-of-range-timestamp-local-tz-conversion.test
M testdata/workloads/functional-query/queries/QueryTest/parquet-def-levels.test
M testdata/workloads/functional-query/queries/QueryTest/parquet-int64-timestamps.test
M testdata/workloads/functional-query/queries/QueryTest/parquet.test
M testdata/workloads/functional-query/queries/QueryTest/select-lazy-timestamp.test
M testdata/workloads/functional-query/queries/QueryTest/subquery.test
A testdata/workloads/functional-query/queries/QueryTest/timestamps.test
M testdata/workloads/functional-query/queries/QueryTest/top-n.test
M testdata/workloads/functional-query/queries/QueryTest/truncate-table.test
M testdata/workloads/functional-query/queries/QueryTest/udf.test
M testdata/workloads/functional-query/queries/QueryTest/union.test
M testdata/workloads/functional-query/queries/QueryTest/utc-timestamp-functions.test
M testdata/workloads/functional-query/queries/QueryTest/views.test
M tests/custom_cluster/test_hive_parquet_timestamp_conversion.py
M tests/data_errors/test_data_errors.py
M tests/hs2/test_fetch.py
M tests/query_test/test_aggregation.py
A tests/query_test/test_timestamps.py
59 files changed, 1,204 insertions(+), 897 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/12498/5
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 5
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3859/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 5
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 03 Mar 2019 22:49:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 3:
(3 comments)
Some high level concerns: this seems like a potentially breaking change, as some workloads may depend on the current way of printing timestamps without subseconds. Adding a flag to change this behavior would be a relatively easy way to avoid breaking things by default.
TimestampValue's ToString() function is used in a lot of places internally. If the goal is to return the results differently to the user, then it is enough to change the way Impala returns timestamps in HS2/Beeswax. Or do you also want to change the way cast(timestamp_column as string) works?
I guess that not every existing test was run, as I would expect a lot of them to fail because of this change. I started a gerrit-verify-dryrun build on jenkins to verify this.
http://gerrit.cloudera.org:8080/#/c/12498/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12498/3//COMMIT_MSG@10
PS3, Line 10:
: seconds if they are all zeros.
nit: long line, commit message lines are capped at 72 characters
http://gerrit.cloudera.org:8080/#/c/12498/3/be/src/runtime/timestamp-value.cc
File be/src/runtime/timestamp-value.cc:
http://gerrit.cloudera.org:8080/#/c/12498/3/be/src/runtime/timestamp-value.cc@211
PS3, Line 211: BOOST_DATE_TIME_POSIX_TIME_STD_CONFIG
What is the role of this config? Generally we assume that Impala works with nanosec precision and lot of tests would break in a different build. If this will be always defined and the #else path is not tested, then I would prefer a compile error if it is not defined.
e.g.
#ifndef BOOST_DATE_TIME_POSIX_TIME_STD_CONFIG
#error "BOOST_DATE_TIME_POSIX_TIME_STD_CONFIG should be defined."
#endif
http://gerrit.cloudera.org:8080/#/c/12498/3/testdata/workloads/functional-query/queries/QueryTest/timestamps.test
File testdata/workloads/functional-query/queries/QueryTest/timestamps.test:
http://gerrit.cloudera.org:8080/#/c/12498/3/testdata/workloads/functional-query/queries/QueryTest/timestamps.test@3
PS3, Line 3:
nit: trailing spaces
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 3
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 17:44:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2138/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 1
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 08:55:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3862/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 6
Gerrit-Owner: Robbie Zhang <rz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 09:50:12 +0000
Gerrit-HasComments: No