[jira] [Commented] (PHOENIX-1007) Replace getNextKeyHint(KeyValue kv) with getNextCellHint(Cell kv) in Filters

["Anoop Sam John (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028838#comment-14028838 ] 

Anoop Sam John commented on PHOENIX-1007:
-----------------------------------------

We were using KeyValueUtil.ensureKeyValue() in other parts of the Filter code.

In HBase master, we are working on changing KV to Cell in read paths. Still the actual object being flowing through read path is KV only. Once this is also changed, we should no longer use KeyValueUtil.ensureKeyValue()  which will be costly copying operation.  

As of now leave it as it is and later we can correct once HBase changes code.    

> Replace getNextKeyHint(KeyValue kv) with getNextCellHint(Cell kv) in Filters
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-1007
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1007
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.0.0, 5.0.0
>            Reporter: Anoop Sam John
>         Attachments: PHOENIX-1007.patch
>
>
> getNextKeyHint(KeyValue kv) is deprecated since 0.96 and will get removed in HBase trunk. Better to replace this with getNextCellHint(Cell kv) now.



--
This message was sent by Atlassian JIRA
(v6.2#6252)