[jira] [Commented] (IMPALA-8917) Including hostnames in debug UI URLs breaks a lot of use cases

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926832#comment-16926832 ] 

ASF subversion and git services commented on IMPALA-8917:
---------------------------------------------------------

Commit de77c61f383794601c79d9783d36235482740417 in impala's branch refs/heads/master from Thomas Tauber-Marshall
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=de77c61 ]

IMPALA-8917: Remove hostname from webui links if Knox isn't being used

IMPALA-8897 added the hostname to all links on the debug webui in
order to facilitate proxying connections through Apache Knox. This
makes the webui difficult to use in situations where the hostname is
not DNS-resolvable.

This patch fixes this by only including the hostname with links if
Knox proxying is actually being used, which we determine by looking
for the 'x-forwarded-context' header in the request, which Knox adds
to all requests.

It also removes the hidden form fields that were added to support Knox
integration when not being accessed through Knox.

It also adds a class comment on Webserver explaining the requirements
for keeping the webui compatible with Knox.

Testing:
- Added a test that checks that links on the webui are made absolute
  when the 'x-forwarded-context' header is in the request.

Change-Id: Ifcf77058dc6ce1d72422a9e3ca7868cdffacff76
Reviewed-on: http://gerrit.cloudera.org:8080/14199
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Including hostnames in debug UI URLs breaks a lot of use cases
> --------------------------------------------------------------
>
>                 Key: IMPALA-8917
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8917
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Infrastructure
>    Affects Versions: Impala 3.4.0
>            Reporter: Tim Armstrong
>            Assignee: Thomas Tauber-Marshall
>            Priority: Blocker
>
> I've run into multiple cases that got broken by IMPALA-8897. The general problem is the assumption that the hostname that the Impala server refers to itself is resolvable by the client accessing the web UI. Cases I've run into:
> * In docker and kubernetes, where the internal hostnames aren't visible outside of the internal network
> * On systems without a DNS-resolvable hostname, e.g. my Ubuntu desktop that I access via a static IP
> I'm not sure what a fix would look like, but I think we at least need some way to work around the problem in situations like this.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org