[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #102: Create intermediate directories for both fixedwindowrollingpolicy and…

[GitBox <gi...@apache.org>]

rm5248 commented on a change in pull request #102:
URL: https://github.com/apache/logging-log4cxx/pull/102#discussion_r785460548



##########
File path: src/main/cpp/rollingpolicybase.cpp
##########
@@ -38,6 +39,7 @@ IMPLEMENT_LOG4CXX_OBJECT(RollingPolicyBase)
 
 RollingPolicyBase::RollingPolicyBase()
 {
+	createIntermediateDirectories = false;

Review comment:
       I had originally had it as `true`, but there's a [test that broke](https://github.com/apache/logging-log4cxx/blob/8988e3e7ced71000e2f1e5c9bd1e282cb766419a/src/test/cpp/rolling/manualrollingtest.cpp#L223) when I did that.  I'm not sure exactly _why_ this test checks for that, but it does.
   
   The [log4j2 appender](https://logging.apache.org/log4j/2.x/manual/appenders.html#FileAppender) does create directories as well.
   
   I think it's perfectly reasonable to change the default to 'true' if you agree.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org