[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5786: network: ipv6 static routes

[GitBox <gi...@apache.org>]

weizhouapache commented on a change in pull request #5786:
URL: https://github.com/apache/cloudstack/pull/5786#discussion_r840908878



##########
File path: systemvm/debian/opt/cloud/bin/cs/CsRedundant.py
##########
@@ -471,6 +469,40 @@ def _remove_ipv6_to_interface(self, interface, ipv6):
             logging.info("IPv6 address %s not present for %s" % (ipv6, dev))
             return
 
+    def _enable_radvd(self, dev, ipv6, dns1, dns2):

Review comment:
       @shwstppr 
   I think it is unnecessary to remove and regenerate `/etc/radvd.conf`.
   
   for isolated networks, it is generated by /opt/cloud/bin/setup/common.sh
   for vpc, it is generated by /opt/cloud/bin/cs/CsVpcGuestNetwork.py
   
   we need to manage (start/stop) service `radvd` in CsRedundant.py




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org