You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tinkoff-dwh <gi...@git.apache.org> on 2017/03/01 08:21:50 UTC
[GitHub] zeppelin pull request #2085: [ZEPPELIN-1999] get interpreter property with r...
GitHub user tinkoff-dwh opened a pull request:
https://github.com/apache/zeppelin/pull/2085
[ZEPPELIN-1999] get interpreter property with replaced context parameters
### What is this PR for?
Adds posibility to use context parameters (types: String.class, Double.class, Float.class, Short.class,
Byte.class, Character.class, Boolean.class, Integer.class, Long.class, ) into property value of interpreter.
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1999
### How should this be tested?
1. Add text with markers #{contextFieldNAme} (ex. #{noteId} or #{paragraphTitle}) to interpreter property value (or add new property of interpreter).
2. Get this property (getProperty(key)), markers should be replaced by context values
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-1999
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2085.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2085
----
commit b5424b99988cc4e87bbb24252b383cb43268a756
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-02-22T09:53:43Z
[ZEPPELIN-1999] get interpreter property with replaced context parameters
commit 527419a1c15d861ee738bfe5b510e7f58d5cfa67
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-02-27T05:05:28Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-1999
# Conflicts:
# zeppelin-interpreter/src/test/java/org/apache/zeppelin/interpreter/InterpreterTest.java
commit 7c4489cfbf5d97d62dccf0616f6352c412317bd1
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-01T06:44:26Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-1999
commit ea9c6a37fd50116e966576eab3a52cf7c2bf07ab
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-01T07:24:01Z
[ZEPPELIN-1999] docs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...
Posted by dwhsys <gi...@git.apache.org>.
Github user dwhsys commented on the issue:
https://github.com/apache/zeppelin/pull/2085
I think that this PR is a great step forward to enterprise version of Zeppelin. Using this feature there will be an ability to implement native integration between different interpreters based on single schema per user / note in core analytical DBMS. Another feature is the possibility of data access control without using credentials.
@felixcheung, @Leemoonsoo, what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...
Posted by mgarmash <gi...@git.apache.org>.
Github user mgarmash commented on the issue:
https://github.com/apache/zeppelin/pull/2085
Nice feature! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2085: [ZEPPELIN-1999] get interpreter property with r...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2085
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2085
1. uniqueness of the marker to replace
2. similar format of the parameters in the note (${}, not the same, not to be confused)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2085: [ZEPPELIN-1999] get interpreter property with r...
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2085
[ZEPPELIN-1999] get interpreter property with replaced context parameters
### What is this PR for?
Adds posibility to use context parameters (types: String.class, Double.class, Float.class, Short.class,
Byte.class, Character.class, Boolean.class, Integer.class, Long.class, ) into property value of interpreter.
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1999
### How should this be tested?
1. Add text with markers #{contextFieldNAme} (ex. #{noteId} or #{replName}) to interpreter property value (or add new property of interpreter).
2. Get this property (getProperty(key)), markers should be replaced by context values
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-1999
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2085.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2085
----
commit b5424b99988cc4e87bbb24252b383cb43268a756
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-02-22T09:53:43Z
[ZEPPELIN-1999] get interpreter property with replaced context parameters
commit 527419a1c15d861ee738bfe5b510e7f58d5cfa67
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-02-27T05:05:28Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-1999
# Conflicts:
# zeppelin-interpreter/src/test/java/org/apache/zeppelin/interpreter/InterpreterTest.java
commit 7c4489cfbf5d97d62dccf0616f6352c412317bd1
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-01T06:44:26Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-1999
commit ea9c6a37fd50116e966576eab3a52cf7c2bf07ab
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-01T07:24:01Z
[ZEPPELIN-1999] docs
commit a10dc0ea673d42fdcd47d022c3e579e3f7a2b398
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-02T13:23:22Z
[ZEPPELIN-1999] skip fields of paragraph
commit 61ac564199ad2f6026c29c6ab70e4ceb02b0da47
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-12T19:58:46Z
[ZEPPELIN-1999] docs
commit c0110e96d773a63141c887131f3e7473c607a68b
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-19T14:06:10Z
[ZEPPELIN-1999] documentation
commit be4fada31f433499f0f3e089637b4eaa8f35f1ba
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-20T04:28:06Z
[ZEPPELIN-1999] revert gitignore
commit 93c759d75485827c591730ebab2ef3d462163a98
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-20T19:28:46Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-1999
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2085: [ZEPPELIN-1999] get interpreter property with r...
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2085
[ZEPPELIN-1999] get interpreter property with replaced context parameters
### What is this PR for?
Adds posibility to use context parameters (types: String.class, Double.class, Float.class, Short.class,
Byte.class, Character.class, Boolean.class, Integer.class, Long.class, ) into property value of interpreter.
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1999
### How should this be tested?
1. Add text with markers #{contextFieldNAme} (ex. #{noteId} or #{replName}) to interpreter property value (or add new property of interpreter).
2. Get this property (getProperty(key)), markers should be replaced by context values
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-1999
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2085.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2085
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...
Posted by andrykrp <gi...@git.apache.org>.
Github user andrykrp commented on the issue:
https://github.com/apache/zeppelin/pull/2085
Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2085: [ZEPPELIN-1999] get interpreter property with r...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2085
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2085
@tinkoff-dwh Saw your latest update. As you did,
```
###### Usage
For example in database exist user `user1` with some password and exists user with same name into Zeppelin. Configure the jdbc interpreter (postgres), set `default.user = #{user}`.
1. Sign in (as `user1`)
2. Open interpreter
3. Execute `select current_user`
```
The above usage example can be added [JDBC interpreter docs](https://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/interpreter/jdbc.html). But it's okay we can update it in later time not in this PR. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2085
Thanks @tinkoff-dwh for useful new feature.
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2085
Ok.
Any other comment? Merging if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2085: [ZEPPELIN-1999] get interpreter property with r...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2085
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2085: [ZEPPELIN-1999] get interpreter property with r...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2085
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2085: [ZEPPELIN-1999] get interpreter property with r...
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2085
[ZEPPELIN-1999] get interpreter property with replaced context parameters
### What is this PR for?
Adds posibility to use context parameters (types: String.class, Double.class, Float.class, Short.class,
Byte.class, Character.class, Boolean.class, Integer.class, Long.class, ) into property value of interpreter.
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1999
### How should this be tested?
1. Add text with markers #{contextFieldNAme} (ex. #{noteId} or #{replName}) to interpreter property value (or add new property of interpreter).
2. Get this property (getProperty(key)), markers should be replaced by context values
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-1999
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2085.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2085
----
commit b5424b99988cc4e87bbb24252b383cb43268a756
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-02-22T09:53:43Z
[ZEPPELIN-1999] get interpreter property with replaced context parameters
commit 527419a1c15d861ee738bfe5b510e7f58d5cfa67
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-02-27T05:05:28Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-1999
# Conflicts:
# zeppelin-interpreter/src/test/java/org/apache/zeppelin/interpreter/InterpreterTest.java
commit 7c4489cfbf5d97d62dccf0616f6352c412317bd1
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-01T06:44:26Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-1999
commit ea9c6a37fd50116e966576eab3a52cf7c2bf07ab
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-01T07:24:01Z
[ZEPPELIN-1999] docs
commit a10dc0ea673d42fdcd47d022c3e579e3f7a2b398
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-02T13:23:22Z
[ZEPPELIN-1999] skip fields of paragraph
commit 61ac564199ad2f6026c29c6ab70e4ceb02b0da47
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-12T19:58:46Z
[ZEPPELIN-1999] docs
commit c0110e96d773a63141c887131f3e7473c607a68b
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-19T14:06:10Z
[ZEPPELIN-1999] documentation
commit be4fada31f433499f0f3e089637b4eaa8f35f1ba
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-20T04:28:06Z
[ZEPPELIN-1999] revert gitignore
commit 93c759d75485827c591730ebab2ef3d462163a98
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-20T19:28:46Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-1999
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2085
I think this is a good feature to have. Let's hold on to get a bit more feedback on this - @Leemoonsoo what do you think about something like this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2085
@felixcheung
Are there problems for merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---