You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2017/05/01 20:17:12 UTC

Re: Review Request 58833: Typedef validations during create/update

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58833/
-----------------------------------------------------------

(Updated May 1, 2017, 8:17 p.m.)


Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.


Changes
-------

Updated commit message and added link to apache JIRA


Bugs: ATLAS-1762
    https://issues.apache.org/jira/browse/ATLAS-1762


Repository: atlas


Description
-------

Following tests

1. Creating a type with super type that doesn\u2019t exist
2. Updating a type with super type that doesn\u2019t exist
3. Creating a type with attribute of unknown data type

throw 404 Not Found error. Expected is 400 Bad Request.


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 82465bfc 


Diff: https://reviews.apache.org/r/58833/diff/2/

Changes: https://reviews.apache.org/r/58833/diff/1-2/


Testing
-------

mvn clean package executes successfully


Thanks,

Apoorv Naik

Re: Review Request 58833: Typedef validations during create/update

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58833/#review173544
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On May 1, 2017, 8:17 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58833/
> -----------------------------------------------------------
> 
> (Updated May 1, 2017, 8:17 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1762
>     https://issues.apache.org/jira/browse/ATLAS-1762
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Following tests
> 
> 1. Creating a type with super type that doesn’t exist
> 2. Updating a type with super type that doesn’t exist
> 3. Creating a type with attribute of unknown data type
> 
> throw 404 Not Found error. Expected is 400 Bad Request.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 82465bfc 
> 
> 
> Diff: https://reviews.apache.org/r/58833/diff/2/
> 
> 
> Testing
> -------
> 
> mvn clean package executes successfully
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>