You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by rj...@apache.org on 2008/09/01 13:50:49 UTC
svn commit: r690944 - /tomcat/current/tc5.5.x/STATUS.txt
Author: rjung
Date: Mon Sep 1 04:50:48 2008
New Revision: 690944
URL: http://svn.apache.org/viewvc?rev=690944&view=rev
Log:
Vote and comment.
Modified:
tomcat/current/tc5.5.x/STATUS.txt
Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=690944&r1=690943&r2=690944&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Mon Sep 1 04:50:48 2008
@@ -34,6 +34,10 @@
point. You could use System.out but that is far worse than the
current proposal given that this will occur once per context with
a default configuration and this is not an error condition.
+ rjung - Is this happening when trying to read a per context logging.properties?
+ If so: then why don't we already have the global logging setup and can use it?
+ I can see, that the code in question is above the general logging setup code,
+ but I would expect readConfiguration() being called for the system class loader first?
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45576
Add support for DIGEST to the JAASRealm
@@ -57,5 +61,5 @@
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45666
Prevent infinite loop on include
http://svn.apache.org/viewvc?rev=690781&view=rev
- +1: markt
+ +1: markt, rjung
-1:
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r690944 - /tomcat/current/tc5.5.x/STATUS.txt
Posted by Rainer Jung <ra...@kippdata.de>.
Mark Thomas wrote:
>> --- tomcat/current/tc5.5.x/STATUS.txt (original)
>> +++ tomcat/current/tc5.5.x/STATUS.txt Mon Sep 1 04:50:48 2008
>> @@ -34,6 +34,10 @@
>> point. You could use System.out but that is far worse than the
>> current proposal given that this will occur once per context with
>> a default configuration and this is not an error condition.
>> + rjung - Is this happening when trying to read a per context logging.properties?
>> + If so: then why don't we already have the global logging setup and can use it?
>> + I can see, that the code in question is above the general logging setup code,
>> + but I would expect readConfiguration() being called for the system class loader first?
>
> I didn't look at this much but by the time this is called for the context
> the global logging has not completed configuration. If you try and get a
> logger you get a stack overflow. Careful coding may be able to avoid this
> but I didn't spend much time looking.
>
> I'd also note we just applied this patch as is to TC6.
I just proposed an alternative solution for tc6.0 and tc5.5.
It works in my tests and seems OK.
If we think it should not keep up the 5.5.27 release, I'm fine with
that, but we should have a final solution ready before 5.5.28.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r690944 - /tomcat/current/tc5.5.x/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
rjung@apache.org wrote:
> Author: rjung
> Date: Mon Sep 1 04:50:48 2008
> New Revision: 690944
>
> URL: http://svn.apache.org/viewvc?rev=690944&view=rev
> Log:
> Vote and comment.
>
> Modified:
> tomcat/current/tc5.5.x/STATUS.txt
>
> Modified: tomcat/current/tc5.5.x/STATUS.txt
> URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=690944&r1=690943&r2=690944&view=diff
> ==============================================================================
> --- tomcat/current/tc5.5.x/STATUS.txt (original)
> +++ tomcat/current/tc5.5.x/STATUS.txt Mon Sep 1 04:50:48 2008
> @@ -34,6 +34,10 @@
> point. You could use System.out but that is far worse than the
> current proposal given that this will occur once per context with
> a default configuration and this is not an error condition.
> + rjung - Is this happening when trying to read a per context logging.properties?
> + If so: then why don't we already have the global logging setup and can use it?
> + I can see, that the code in question is above the general logging setup code,
> + but I would expect readConfiguration() being called for the system class loader first?
I didn't look at this much but by the time this is called for the context
the global logging has not completed configuration. If you try and get a
logger you get a stack overflow. Careful coding may be able to avoid this
but I didn't spend much time looking.
I'd also note we just applied this patch as is to TC6.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org