[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #14750: GH-14720: Update merge_arrow_pr script to accept GitHub issues

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on code in PR #14750:
URL: https://github.com/apache/arrow/pull/14750#discussion_r1034692746


##########
dev/merge_arrow_pr.py:
##########
@@ -581,20 +677,20 @@ def cli():
 
     pr.merge()
 
-    if pr.jira_issue is None:
-        print("Minor PR.  No JIRA issue to update.\n")
+    if pr.issue is None:
+        print("Minor PR.  No issue to update.\n")
         return
 
-    cmd.continue_maybe("Would you like to update the associated JIRA?")
-    jira_comment = (
+    cmd.continue_maybe("Would you like to update the associated issue?")
+    issue_comment = (
         "Issue resolved by pull request %s\n[%s/%s]"

Review Comment:
   For posting this on GitHub issues, the formatting doesn't need to include the `[` `]` (I would personally also remove the newline and double PR number/url for GitHub (since the url gets rendered as a number anyway)
   
   So something like
   
   "Issue resolved by pull request GH-%s" with just the pr_num (or using the full url, and then the message can maybe be the same for both JIRA and GitHub)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org