You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/08/16 14:04:40 UTC

[GitHub] [commons-geometry] darkma773r opened a new pull request #181: Changes from release feedback

darkma773r opened a new pull request #181:
URL: https://github.com/apache/commons-geometry/pull/181


   - Use `0` instead of `0.0` in if condition comparison
   - Rename boolean getter methods to follow `isXXX` convention
   - Add test for `AbstractNode.depth()` for detached nodes
   - Remove inline checkstyle comments
   - Fix user guide typos
   - Use `String.toLowerCase(Locale.ROOT)` in `BoundaryIOManager`
   - Use explicit `long` to `int` cast
   - Remove unnecessary `if` condition
   - Add javadoc external links
   - Fix javadoc reference 
   - Update PMD config


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-geometry] aherbert commented on pull request #181: Changes from release feedback

Posted by GitBox <gi...@apache.org>.
aherbert commented on pull request #181:
URL: https://github.com/apache/commons-geometry/pull/181#issuecomment-899624652


   Yes. I think the issue with javadoc links to numbers is now a problem with the numbers site for the javadoc directories.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-geometry] darkma773r commented on a change in pull request #181: Changes from release feedback

Posted by GitBox <gi...@apache.org>.
darkma773r commented on a change in pull request #181:
URL: https://github.com/apache/commons-geometry/pull/181#discussion_r689641657



##########
File path: src/main/resources/pmd/pmd-ruleset.xml
##########
@@ -41,12 +41,14 @@
     <exclude name="UseUnderscoresInNumericLiterals" />
     <exclude name="GenericsNaming" />
     <exclude name="ConfusingTernary" />
+    <exclude name="FieldDeclarationsShouldBeAtStartOfClass" />

Review comment:
       No. I disagree with this in some cases since I often find it helpful to have frequently used inner types (particularly public enums and interfaces) at the top of the class.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-geometry] asfgit merged pull request #181: Changes from release feedback

Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #181:
URL: https://github.com/apache/commons-geometry/pull/181


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-geometry] darkma773r commented on pull request #181: Changes from release feedback

Posted by GitBox <gi...@apache.org>.
darkma773r commented on pull request #181:
URL: https://github.com/apache/commons-geometry/pull/181#issuecomment-899621026


   Thanks, @aherbert. Are we good to go for another RC after I merge this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-geometry] aherbert commented on a change in pull request #181: Changes from release feedback

Posted by GitBox <gi...@apache.org>.
aherbert commented on a change in pull request #181:
URL: https://github.com/apache/commons-geometry/pull/181#discussion_r689627741



##########
File path: src/main/resources/pmd/pmd-ruleset.xml
##########
@@ -41,12 +41,14 @@
     <exclude name="UseUnderscoresInNumericLiterals" />
     <exclude name="GenericsNaming" />
     <exclude name="ConfusingTernary" />
+    <exclude name="FieldDeclarationsShouldBeAtStartOfClass" />

Review comment:
       Is it the intention to put this back in the future?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org