[GitHub] [doris] freemandealer commented on issue #17333: [Enhancement] better merge single_replica_load_rpc_service into brpc_service

["freemandealer (via GitHub)" <gi...@apache.org>]

freemandealer commented on issue #17333:
URL: https://github.com/apache/doris/issues/17333#issuecomment-1502995143

   > Using bthread's condition variable instead of std::condition_variable may not work under the current case, because bthreads for brpc requests are not working upon the work_pool of ourselves.
   
   There are some misunderstandings. My logic is as follows:
   
   - Merge two services into one
   - If there are any problems, replace with bthread mutex to verify my assumption written above.
   
   So using bthread mutex was just a verification method originally. Chenlinzhong’s modification of the RPC handling framework last month has confirmed my assumption and fixed it with another elegant method. With his fix, there is no need to use bthread mutex anymore (but not completely useless, see below).
   
   Now let’s stop discussing historical issues and discuss the next steps based on the current situation.
   
   Because of chenlinzhong's brilliant solution, our service merging task has become easier ever than before: just do the merge and ... done, right?
   
   Even if RPC processing and business processing are separated, if all underlying pthreads are occupied, blocking problems still happens. In the end, we still need to avoid blocking pthreads as much as possible. Getting rid of std::mutex is still an important way to do so.
   
   No worry. If we find any problems during subsequent stress testing, we can analyze them case by case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org