You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/04 15:08:05 UTC

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #1712: ESP32: Add support for an external MMCSD card over SPI and fix receving data.

Ouss4 opened a new pull request #1712:
URL: https://github.com/apache/incubator-nuttx/pull/1712


   ## Summary
   - The SPI driver was not receiving data when exchanging a block with an empty TX buffer. 
   Dummy data was needed to kick off the SPI clock.
   
   - Add an example of an external MMCSD card over SPI.
   
   ## Impact
   Fix SPI reception.
   
   ## Testing
   Provided mmcsdspi config.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #1712: ESP32: Add support for an external MMCSD card over SPI and fix receving data.

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1712:
URL: https://github.com/apache/incubator-nuttx/pull/1712#issuecomment-687272951


   Hi Abde, if you should be interesting to include some information in the README.txt about this config and how wire the SDCard adapter, it will make users' life easier.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #1712: ESP32: Add support for an external MMCSD card over SPI and fix receving data.

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1712:
URL: https://github.com/apache/incubator-nuttx/pull/1712#issuecomment-687271274


   Thank you very much Abde!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #1712: ESP32: Add support for an external MMCSD card over SPI and fix receving data.

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #1712:
URL: https://github.com/apache/incubator-nuttx/pull/1712


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1712: ESP32: Add support for an external MMCSD card over SPI and fix receving data.

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1712:
URL: https://github.com/apache/incubator-nuttx/pull/1712#issuecomment-687283945


   > Hi Abde, if you should be interesting to include some information in the README.txt about this config and how wire the SDCard adapter, it will make users' life easier.
   
   Oh yes, I forgot about it.  I'll do it when I get back to my computer.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #1712: ESP32: Add support for an external MMCSD card over SPI and fix receving data.

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1712:
URL: https://github.com/apache/incubator-nuttx/pull/1712#issuecomment-687372902


   I will merge it, because it passed in the previous run and there is not obvious issue here


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org