[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #649: HDDS-3120. Freon work with OM HA.

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #649: HDDS-3120. Freon work with OM HA.
URL: https://github.com/apache/hadoop-ozone/pull/649#discussion_r390462290
 
 

 ##########
 File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java
 ##########
 @@ -469,4 +456,13 @@ public AtomicLong getAttemptCounter() {
   public int getThreadNo() {
     return threadNo;
   }
+
+  protected OzoneClient createOzoneClient(String omServiceID,
+      OzoneConfiguration conf) throws Exception {
+    if (omServiceID != null) {
+      return OzoneClientFactory.getRpcClient(omServiceID, conf);
+    } else {
+      return OzoneClientFactory.getRpcClient(conf);
 
 Review comment:
   Removed getClient, and used getRpcClient, to avoid these kind of mistakes instead of duplicating the same code in multiple functions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org