You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/18 23:35:39 UTC

[GitHub] [incubator-superset] nytai opened a new issue #8865: deprecate tslint in favor of eslint w/ typescript support

nytai opened a new issue #8865: deprecate tslint in favor of eslint w/ typescript support
URL: https://github.com/apache/incubator-superset/issues/8865
 
 
   Having written some typescript in the repo I found the tslint rules to be very strict. Rules like alphabetizing object keys, not allowing lambdas in jsx, not allowing multiline expressions in jsx, among others don't coincide with the eslint rules and are not autofixable. 
   
   In order to increase adoption of typescript in the repo I think it would be good to have the typescript developer experience to be as close to the current javascript experience. Also, it looks like the creators of tslint are [recommending not using that library anymore](https://medium.com/palantir/tslint-in-2019-1a144c2317a9). 
   
   We should configure eslint to support typescript and try to have as many of the same rules in both environments as possible. Info on how to implement this: https://codeburst.io/from-eslint-to-tslint-and-back-again-bf259c2e7437

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 closed issue #8865: deprecate tslint in favor of eslint w/ typescript support

Posted by GitBox <gi...@apache.org>.
etr2460 closed issue #8865: deprecate tslint in favor of eslint w/ typescript support
URL: https://github.com/apache/incubator-superset/issues/8865
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kristw commented on issue #8865: deprecate tslint in favor of eslint w/ typescript support

Posted by GitBox <gi...@apache.org>.
kristw commented on issue #8865: deprecate tslint in favor of eslint w/ typescript support
URL: https://github.com/apache/incubator-superset/issues/8865#issuecomment-583650888
 
 
   Those repositories use `eslint` with `typescript`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kristw edited a comment on issue #8865: deprecate tslint in favor of eslint w/ typescript support

Posted by GitBox <gi...@apache.org>.
kristw edited a comment on issue #8865: deprecate tslint in favor of eslint w/ typescript support
URL: https://github.com/apache/incubator-superset/issues/8865#issuecomment-583650888
 
 
   Those repositories use `eslint` with `typescript` support.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] williaster commented on issue #8865: deprecate tslint in favor of eslint w/ typescript support

Posted by GitBox <gi...@apache.org>.
williaster commented on issue #8865: deprecate tslint in favor of eslint w/ typescript support
URL: https://github.com/apache/incubator-superset/issues/8865#issuecomment-584315761
 
 
   standardizing on the `nimbus` build configs from `superset-ui` + `superset-ui-plugins` repos seems like it could be a good idea. then it's one thing to learn across all repos.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org