You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Alexandre Castro Alves (JIRA)" <ji...@apache.org> on 2012/06/15 16:38:42 UTC

[jira] [Commented] (BEANUTILS-278) Remove copied Collections classes

    [ https://issues.apache.org/jira/browse/BEANUTILS-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295692#comment-13295692 ] 

Alexandre Castro Alves commented on BEANUTILS-278:
--------------------------------------------------

Is this still being planned?

I am running into a class-loading problem in an OSGi environment because of the duplicate FastHashMap. In my case, other bundles are importing the FastHashMap from commons.collection and passing it along as an argument to beanutils, which then collides with the internal copy of the FasthHashMap.

Can we please take a look at this with some urgency?

You should either import as well from commons.collections or rely only on Map/HashMap, as in the proposed patch.

Thanks
Alex
                
> Remove copied Collections classes
> ---------------------------------
>
>                 Key: BEANUTILS-278
>                 URL: https://issues.apache.org/jira/browse/BEANUTILS-278
>             Project: Commons BeanUtils
>          Issue Type: Improvement
>    Affects Versions: 1.7.0
>            Reporter: Niall Pemberton
>             Fix For: LATER THAN 1.8.4
>
>         Attachments: Beanutils-278-2.patch
>
>
> The following 4 Commons Collections classes were copied into BeanUtils so that the dependency on Commons Collections could be removed (these were included in the BeanUtils 1.7.0 release)
>     ArrayStack.java
>     Buffer.java
>     BufferUnderflowException.java
>     FastHashMap.java
> See the following thread for the original reasoning:
>     http://tinyurl.com/yvma2q
>     http://tinyurl.com/2hs3hp
> Recent discussion thread on this issue is here:
>     http://tinyurl.com/2vyuk8
> Of the above four classes only FastHashMap is used within BeanUtils (and is part of the public API) - not sure why the other classes were included, but it may be because downstream systems such as Struts depend on them (which also removed its Commons Collections when it moved to BeanUtils 1.7.0). Some (but not all) of the BeanUtils public API which exposes FastHashMap was deprecated in the BeanUtils 1.7.0 release.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira