You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2018/06/05 18:38:11 UTC
[Impala-ASF-CR] Add missing namespace qualifiers
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10608
Change subject: Add missing namespace qualifiers
......................................................................
Add missing namespace qualifiers
As part of an upcoming rebase of the KRPC code, this change adds missing
namespace qualifiers in some places.
Change-Id: I3ef8f5c8f05100418dec90c2cd2e2b3dcd827c27
---
M be/src/exec/kudu-util.h
M be/src/runtime/descriptors.h
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/10608/1
--
To view, visit http://gerrit.cloudera.org:8080/10608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ef8f5c8f05100418dec90c2cd2e2b3dcd827c27
Gerrit-Change-Number: 10608
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] Add missing namespace qualifiers
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10608 )
Change subject: Add missing namespace qualifiers
......................................................................
Add missing namespace qualifiers
As part of an upcoming rebase of the KRPC code, this change adds missing
namespace qualifiers in some places.
Change-Id: I3ef8f5c8f05100418dec90c2cd2e2b3dcd827c27
Reviewed-on: http://gerrit.cloudera.org:8080/10608
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/kudu-util.h
M be/src/runtime/descriptors.h
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ef8f5c8f05100418dec90c2cd2e2b3dcd827c27
Gerrit-Change-Number: 10608
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Add missing namespace qualifiers
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10608 )
Change subject: Add missing namespace qualifiers
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2599/
--
To view, visit http://gerrit.cloudera.org:8080/10608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ef8f5c8f05100418dec90c2cd2e2b3dcd827c27
Gerrit-Change-Number: 10608
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jun 2018 18:48:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add missing namespace qualifiers
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10608 )
Change subject: Add missing namespace qualifiers
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ef8f5c8f05100418dec90c2cd2e2b3dcd827c27
Gerrit-Change-Number: 10608
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jun 2018 22:34:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add missing namespace qualifiers
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10608 )
Change subject: Add missing namespace qualifiers
......................................................................
Patch Set 1: Code-Review+2
Thanks! Seems ok to go in now.
--
To view, visit http://gerrit.cloudera.org:8080/10608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ef8f5c8f05100418dec90c2cd2e2b3dcd827c27
Gerrit-Change-Number: 10608
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jun 2018 18:43:50 +0000
Gerrit-HasComments: No