[jira] [Commented] (SPARK-21136) Misleading error message for typo in SQL

["Vitaly Gerasimov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-21136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214909#comment-16214909 ] 

Vitaly Gerasimov commented on SPARK-21136:
------------------------------------------

Same problem:
{code}
sql.sql("select * from test where t is like \"test\"").show()
org.apache.spark.sql.catalyst.parser.ParseException:
mismatched input 'from' expecting {<EOF>, 'WHERE', 'GROUP', 'ORDER', 'HAVING', 'LIMIT', 'LATERAL', 'WINDOW', 'UNION', 'EXCEPT', 'MINUS', 'INTERSECT', 'SORT', 'CLUSTER', 'DISTRIBUTE'}(line 1, pos 9)

== SQL ==
select * from test where test.t is like "test"
---------^^^
{code}

> Misleading error message for typo in SQL
> ----------------------------------------
>
>                 Key: SPARK-21136
>                 URL: https://issues.apache.org/jira/browse/SPARK-21136
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 2.1.0
>            Reporter: Daniel Darabos
>            Priority: Minor
>
> {code}
> scala> spark.sql("select * from a left joinn b on a.id = b.id").show
> org.apache.spark.sql.catalyst.parser.ParseException:
> mismatched input 'from' expecting {<EOF>, 'WHERE', 'GROUP', 'ORDER', 'HAVING', 'LIMIT', 'LATERAL', 'WINDOW', 'UNION', 'EXCEPT', 'MINUS', 'INTERSECT', 'SORT', 'CLUSTER', 'DISTRIBUTE'}(line 1, pos 9)
> == SQL ==
> select * from a left joinn b on a.id = b.id
> ---------^^^
> {code}
> The issue is that {{^^^}} points at {{from}}, not at {{joinn}}. The text of the error makes no sense either. If {{*}}, {{a}}, and {{b}} are complex in themselves, a misleading error like this can hinder debugging substantially.
> I tried to see if maybe I could fix this. Am I correct to deduce that the error message originates in ANTLR4, which parses the query based on the syntax defined in {{SqlBase.g4}}? If so, I guess I would have to figure out how that syntax definition works, and why it misattributes the error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org