You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/07 17:58:28 UTC

[GitHub] [beam] johnjcasey commented on a diff in pull request #23011: (BQ Python) Pass project field from options or parameter when writing with dynamic destinations

johnjcasey commented on code in PR #23011:
URL: https://github.com/apache/beam/pull/23011#discussion_r965130397


##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -2278,8 +2278,8 @@ def expand(self, pcoll):
 
     if (isinstance(self.table_reference, TableReference) and
         self.table_reference.projectId is None):
-      self.table_reference.projectId = pcoll.pipeline.options.view_as(
-          GoogleCloudOptions).project
+      self.table_reference.projectId = self._project or \

Review Comment:
   Because this overrides the existing default, we should add a comment to that effect if someone passes the project flag in



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org